Skip to content

Upgrade to halogen master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2015
Merged

Conversation

passy
Copy link
Contributor

@passy passy commented Sep 6, 2015

I don't know what your upgrade policy is, but it's just an import that has changed since the last sync with halogen master.

Review on Reviewable

@puffnfresh
Copy link

Travis says there's a conflict now. Need to expand the purescript-strings upper bound.

@passy
Copy link
Contributor Author

passy commented Sep 10, 2015

Will take care of that later. :)

On Thu, Sep 10, 2015, 03:28 Brian McKenna [email protected] wrote:

Travis says there's a conflict now. Need to expand the purescript-strings
upper bound.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@passy
Copy link
Contributor Author

passy commented Sep 10, 2015

There's an odd testing failure I've observed on Travis with a different project, too. I'm not quite sure where it comes from. It seems like an issue with the paths. Running pulp still passes for me locally.

@puffnfresh
Copy link

@passy the problem is using PureScript 0.7.3 - Halogen needs 0.7.4 to work. I've observed this many times over the past few weeks 😿

@puffnfresh
Copy link

@passy I'd merge this but don't have permissions anymore. @garyb will probably do it.

@jdegoes
Copy link
Contributor

jdegoes commented Sep 10, 2015

Travis still failing

@passy
Copy link
Contributor Author

passy commented Sep 11, 2015

@puffnfresh Ah, of course. Thanks!

Bumped the purescript dep, tests are finally passing again. :)

garyb added a commit that referenced this pull request Sep 11, 2015
@garyb garyb merged commit b7b2296 into purescript-halogen:master Sep 11, 2015
@passy passy deleted the halogen-upgrade branch September 12, 2015 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants