Update write/writeString/end to take Maybe Error arg

Author: JordanMartinez

src/Node/Stream.js

@@ -102,7 +102,7 @@ export function readImpl(readChunk) {
   };
 }
 
-export function write(w) {
+export function writeImpl(w) {
   return chunk => done => () => w.write(chunk, null, done);
 }
 
@@ -124,11 +124,9 @@ export function setDefaultEncodingImpl(w) {
   };
 }
 
-export function end(w) {
+export function endImpl(w) {
   return done => () => {
-    w.end(null, null, () => {
-      done();
-    });
+    w.end(null, null, done);
   };
 }
 

src/Node/Stream.purs

@@ -37,10 +37,12 @@ module Node.Stream
 import Prelude
 
 import Effect (Effect)
-import Effect.Exception (throw, Error())
+import Effect.Exception (throw, Error)
 import Data.Either (Either(..))
 import Data.Maybe (Maybe(..), fromMaybe)
-import Node.Buffer (Buffer())
+import Node.Buffer (Buffer)
+import Data.Nullable as N
+import Effect.Uncurried (EffectFn1, mkEffectFn1)
 import Node.Buffer as Buffer
 import Node.Encoding (Encoding)
 
@@ -249,20 +251,28 @@ foreign import unpipeAll
    . Readable w
   -> Effect Unit
 
+foreign import writeImpl
+  :: forall r
+   . Writable r
+  -> Buffer
+  -> EffectFn1 (N.Nullable Error) Unit
+  -> Effect Boolean
+
 -- | Write a Buffer to a writable stream.
-foreign import write
+write
   :: forall r
    . Writable r
   -> Buffer
-  -> (Error -> Effect Unit)
+  -> (Maybe Error -> Effect Unit)
   -> Effect Boolean
+write w b cb = writeImpl w b $ mkEffectFn1 (cb <<< N.toMaybe)
 
 foreign import writeStringImpl
   :: forall r
    . Writable r
   -> String
   -> String
-  -> (Error -> Effect Unit)
+  -> EffectFn1 (N.Nullable Error) Unit
   -> Effect Boolean
 
 -- | Write a string in the specified encoding to a writable stream.
@@ -271,9 +281,9 @@ writeString
    . Writable r
   -> Encoding
   -> String
-  -> (Error -> Effect Unit)
+  -> (Maybe Error -> Effect Unit)
   -> Effect Boolean
-writeString w enc = writeStringImpl w (show enc)
+writeString w enc s cb = writeStringImpl w (show enc) s $ mkEffectFn1 (cb <<< N.toMaybe)
 
 -- | Force buffering of writes.
 foreign import cork :: forall r. Writable r -> Effect Unit
@@ -299,12 +309,19 @@ setDefaultEncoding
   -> Effect Unit
 setDefaultEncoding r enc = setDefaultEncodingImpl r (show enc)
 
--- | End writing data to the stream.
-foreign import end
+foreign import endImpl
   :: forall r
    . Writable r
+  -> EffectFn1 (N.Nullable Error) Unit
   -> Effect Unit
+
+-- | End writing data to the stream.
+end
+  :: forall r
+   . Writable r
+  -> (Maybe Error -> Effect Unit)
   -> Effect Unit
+end w cb = endImpl w $ mkEffectFn1 (cb <<< N.toMaybe)
 
 -- | Destroy the stream. It will release any internal resources.
 --