Skip to content

Generalize Exists to hold non-Type-kinded types #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2021
Merged

Generalize Exists to hold non-Type-kinded types #14

merged 2 commits into from
Jun 25, 2021

Conversation

rhendric
Copy link
Member

@rhendric rhendric commented Feb 10, 2021 •
edited
Loading

Description of the change

With polymorphic kinds, Exists can be generalized to quantify over types of kind other than Type. I don't believe there's any disadvantage to doing so.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@rhendric rhendric force-pushed the rhendric/generalize-exists branch from 7f47cbe to 9fa359a Compare February 10, 2021 21:49
JordanMartinez
JordanMartinez reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine to me. However, is there a way to test the code without needing to add FFI?

@rhendric
Copy link
Member Author

Easy enough; how's that?

JordanMartinez
JordanMartinez approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@thomashoneyman thomashoneyman merged commit c083da6 into purescript:master Jun 25, 2021
@rhendric rhendric deleted the rhendric/generalize-exists branch June 25, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhendric @JordanMartinez @thomashoneyman