Skip to content

Commit 892e21d

Browse files
jpatel531jpatel531
committed
Tests and validations
1 parent fd9a375 commit 892e21d

File tree

3 files changed

+250
-1
lines changed

3 files changed

+250
-1
lines changed

‎lib/notification_client.js

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,85 @@ var requests = require('./requests');
33
var util = require('./util');
44
var NotificationConfig = require('./notification_config');
55

6+
var RESTRICTED_GCM_KEYS = ['to', 'registration_ids'];
7+
var GCM_TTL = 241920;
8+
var WEBHOOK_LEVELS = {
9+
"INFO": true,
10+
"DEBUG": true,
11+
"": true
12+
}
13+
614
function NotificationClient(options){
715
this.config = new NotificationConfig(options);
816
}
917

1018
NotificationClient.prototype.notify = function(interests, notification, callback) {
19+
if (!Array.isArray(interests)) {
20+
throw new Error("Interests must be an array");
21+
}
22+
23+
if (interests.length != 1) {
24+
throw new Error("Currently sending to more than one interest is unsupported")
25+
}
26+
27+
1128
var body = util.mergeObjects({interests: interests}, notification);
29+
this.validateNotification(body);
1230
requests.send(this.config, {
1331
method: "POST",
1432
body: body,
1533
path: "/notification"
1634
}, callback);
1735
}
1836

37+
NotificationClient.prototype.validateNotification = function(notification) {
38+
var gcmPayload = notification.gcm;
39+
if (!gcmPayload && !notification.apns) {
40+
throw new Error("Notification must have fields APNS or GCM");
41+
}
42+
43+
if (gcmPayload) {
44+
for (var index in RESTRICTED_GCM_KEYS) {
45+
var restrictedKey = RESTRICTED_GCM_KEYS[index];
46+
delete(gcmPayload[restrictedKey]);
47+
}
48+
49+
var ttl = gcmPayload.time_to_live;
50+
if (ttl) {
51+
if (isNaN(ttl)) {
52+
throw new Error("provided ttl must be a number");
53+
}
54+
55+
if (!(ttl > 0 && ttl < GCM_TTL)) {
56+
throw new Error("GCM time_to_live must be between 0 and 241920 (4 weeks)");
57+
}
58+
}
59+
60+
var gcmPayloadNotification = gcmPayload.notification;
61+
if (gcmPayloadNotification) {
62+
var title = gcmPayloadNotification.title;
63+
var icon = gcmPayloadNotification.icon;
64+
var requiredFields = [title, icon];
65+
66+
if (typeof(title) !== 'string' || title.length === 0) {
67+
throw new Error("GCM title must be a string and not empty");
68+
}
69+
70+
if (typeof(icon) !== 'string' || icon.length === 0) {
71+
throw new Error("GCM icon must be a string and not empty");
72+
}
73+
}
74+
}
75+
76+
var webhookURL = notification.webhook_url;
77+
var webhookLevel = notification.webhook_level;
78+
79+
if (webhookLevel) {
80+
if (!webhookURL) throw new Error("webhook_level cannot be used without a webhook_url");
81+
if (!WEBHOOK_LEVELS[webhookLevel]) {
82+
throw new Error("webhook_level must be either INFO or DEBUG. Blank will default to INFO");
83+
}
84+
}
85+
}
86+
1987
module.exports = NotificationClient;

‎lib/notification_config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var Config = require('./config');
22
var util = require('./util');
33

4-
var DEFAULT_HOST = "yolo.ngrok.io";
4+
var DEFAULT_HOST = "nativepushclient-cluster1.pusher.com";
55
var API_PREFIX = "customer_api";
66
var API_VERSION = "v1";
77

‎tests/integration/pusher/notification_client.js

Lines changed: 181 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,181 @@
1+
var expect = require("expect.js");
2+
var NotificationClient = require("../../../lib/notification_client");
3+
var nock = require('nock');
4+
5+
describe("NativeNotificationClient", function() {
6+
var client;
7+
8+
beforeEach(function(){
9+
client = new NotificationClient({ appId: 1234, key: "f00d", secret: "beef" });
10+
nock.cleanAll();
11+
nock.disableNetConnect();
12+
});
13+
14+
afterEach(function() {
15+
nock.cleanAll();
16+
nock.enableNetConnect();
17+
});
18+
19+
xit("should send in the success case", function(done){
20+
var mock = nock("nativepushclient-cluster1.pusher.com:80")
21+
client.notify(['yolo'],{
22+
'apns': {
23+
'aps': {
24+
'alert':{
25+
'title': 'yolo',
26+
'body': 'woot'
27+
}
28+
}
29+
},
30+
'gcm': {
31+
'notification': {
32+
'title': 'huzzah',
33+
'icon': 'woot'
34+
}
35+
}
36+
37+
}, function(){
38+
expect(mock.isDone()).to.be(true);
39+
done();
40+
});
41+
});
42+
43+
it("should remove restricted GCM keys", function(){
44+
var notification = {
45+
'gcm': {
46+
'to': 'woot',
47+
'registration_ids': ['woot', 'bla'],
48+
'notification': {
49+
'title': 'yipee',
50+
'icon': 'huh'
51+
}
52+
}
53+
};
54+
55+
client.validateNotification(notification);
56+
expect(notification).to.eql({ gcm: { notification: { title: 'yipee', icon: 'huh' }}});
57+
});
58+
59+
it("should validate that either apns or gcm are present", function(){
60+
var notification = {};
61+
expect(function(){
62+
client.validateNotification(notification);
63+
}).to.throwException(/Notification must have fields APNS or GCM/);
64+
});
65+
66+
it("should validate that only one interest is sent to", function(){
67+
expect(function(){
68+
client.notify(['yolo', 'woot'], {});
69+
}).to.throwException(/Currently sending to more than one interest is unsupported/);
70+
})
71+
72+
it("should invalidate certain gcm payloads", function(){
73+
var invalidGcmPayloads = [
74+
{
75+
'gcm': {
76+
'time_to_live': -1,
77+
'notification': {
78+
'title': 'yipee',
79+
'icon': 'huh'
80+
}
81+
},
82+
exception: /GCM time_to_live must be between 0 and 241920 \(4 weeks\)/
83+
},
84+
{
85+
'gcm': {
86+
'time_to_live': 241921,
87+
'notification': {
88+
'title': 'yipee',
89+
'icon': 'huh'
90+
}
91+
},
92+
exception: /GCM time_to_live must be between 0 and 241920 \(4 weeks\)/
93+
},
94+
{
95+
'gcm': {
96+
'notification': {
97+
'title': 'yipee',
98+
}
99+
},
100+
exception: /GCM icon must be a string and not empty/
101+
},
102+
{
103+
'gcm': {
104+
'notification': {
105+
'icon': 'huh'
106+
}
107+
},
108+
exception: /GCM title must be a string and not empty/
109+
},
110+
{
111+
'gcm': {
112+
'notification': {
113+
'title': '',
114+
'icon': 'huh'
115+
}
116+
},
117+
exception: /GCM title must be a string and not empty/
118+
},
119+
{
120+
'gcm': {
121+
'notification': {
122+
'title': 'yipee',
123+
'icon': ''
124+
}
125+
},
126+
exception: /GCM icon must be a string and not empty/
127+
}
128+
]
129+
130+
for (var index in invalidGcmPayloads) {
131+
var invalidPayload = invalidGcmPayloads[index];
132+
expect(function(){
133+
client.notify(['yolo'], invalidPayload);
134+
}).to.throwException(invalidPayload.exception || /%/);
135+
}
136+
});
137+
138+
it("validates webhook config", function(){
139+
invalidWebhookConfig = [
140+
{
141+
'webhook_level': 'DEBUG',
142+
'apns': {
143+
'alert': {
144+
'title': 'yolo',
145+
'body': 'woot'
146+
}
147+
},
148+
'gcm': {
149+
'notification': {
150+
'title': 'yipee',
151+
'icon': 'huh'
152+
}
153+
},
154+
exception: 'webhook_level cannot be used without a webhook_url'
155+
},
156+
{
157+
'webhook_level': 'FOOBAR',
158+
'webhook_url': 'http://webhook.com',
159+
'apns': {
160+
'alert': {
161+
'title': 'yolo',
162+
'body': 'woot'
163+
}
164+
},
165+
'gcm': {
166+
'notification': {
167+
'title': 'yipee',
168+
'icon': 'huh'
169+
}
170+
},
171+
exception: 'webhook_level must be either INFO or DEBUG. Blank will default to INFO'
172+
}];
173+
174+
for (var index in invalidWebhookConfig) {
175+
var invalidPayload = invalidWebhookConfig[index];
176+
expect(function(){
177+
client.notify(['yolo'], invalidPayload);
178+
}).to.throwException(new RegExp(invalidPayload.exception));
179+
}
180+
})
181+
})

0 commit comments

Comments
 (0)