Merge pull request #10 from pusher/ci-support

CI support for React Native SDK

Author: fbenevides

.github/workflows/ci.yml

@@ -0,0 +1,18 @@
+on:
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Yarn install
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: yarn install --cwd example --frozen-lockfile
+    - run: yarn install --frozen-lockfile
+    - run: yarn typescript
+    - run: yarn lint

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.0.0-beta1
+
+* [FIXED] Fixed required dependencies on README
+* [ADDED] Add Lint support for Pull Requests
+* [CHANGED] Executed Lint on Example app
+
 ## 0.0.1-beta1
 
 * [ADDED] First beta release 🥳

example/src/App.tsx

@@ -15,7 +15,7 @@ import {
   Pusher,
   PusherMember,
   PusherChannel,
-  PusherEvent
+  PusherEvent,
 } from 'pusher-websocket-react-native';
 
 export default function App() {
@@ -44,6 +44,8 @@ export default function App() {
       onChangeEventData((await AsyncStorage.getItem('DATA')) || '');
     };
     getFromStorage().catch((e) => log('ERROR: ' + e));
+
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   const connect = async () => {
@@ -80,7 +82,9 @@ export default function App() {
     currentState: string,
     previousState: string
   ) => {
-    log(`onConnectionStateChange. previousState=${previousState} newState=${currentState}`);
+    log(
+      `onConnectionStateChange. previousState=${previousState} newState=${currentState}`
+    );
   };
 
   const onError = (message: string, code: Number, error: any) => {
@@ -101,7 +105,11 @@ export default function App() {
     log(`Me: ${me}`);
   };
 
-  const onSubscriptionError = (channelName: string, message: string, e: any) => {
+  const onSubscriptionError = (
+    channelName: string,
+    message: string,
+    e: any
+  ) => {
     log(`onSubscriptionError: ${message}, channelName: ${channelName} e: ${e}`);
   };
 
@@ -174,7 +182,7 @@ export default function App() {
           <Button
             title="Connect"
             onPress={connect}
-            disabled={!Boolean(apiKey && cluster && channelName)}
+            disabled={!(apiKey && cluster && channelName)}
           />
         </>
       ) : (
@@ -207,7 +215,7 @@ export default function App() {
           <Button
             title="Trigger Event"
             onPress={trigger}
-            disabled={!Boolean(eventName)}
+            disabled={!eventName}
           />
         </>
       )}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pusher/pusher-websocket-react-native",
-  "version": "0.0.1-beta1",
+  "version": "1.0.0-beta1",
   "description": "Pusher Channels Client for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

scripts/bootstrap.js

@@ -12,7 +12,7 @@ const options = {
 };
 
 if (os.type() === 'Windows_NT') {
-  options.shell = true
+  options.shell = true;
 }
 
 let result;

src/index.tsx

@@ -84,7 +84,7 @@ export class PusherChannel {
   }
 
   async trigger(event: PusherEvent) {
-    if (event.channelName != this.channelName) {
+    if (event.channelName !== this.channelName) {
       throw 'Event is not for this channel';
     }
     return Pusher.getInstance().trigger(event);
@@ -129,7 +129,11 @@ export class Pusher {
     onError?: (message: string, code: Number, e: any) => void;
     onEvent?: (event: PusherEvent) => void;
     onSubscriptionSucceeded?: (channelName: string, data: any) => void;
-    onSubscriptionError?: (channelName: string, message: string, e: any) => void;
+    onSubscriptionError?: (
+      channelName: string,
+      message: string,
+      e: any
+    ) => void;
     onDecryptionFailure?: (eventName: string, reason: string) => void;
     onMemberAdded?: (channelName: string, member: PusherMember) => void;
     onMemberRemoved?: (channelName: string, member: PusherMember) => void;
@@ -161,7 +165,7 @@ export class Pusher {
             const userInfo = decodedData?.presence?.hash[_userId];
             var member = new PusherMember(_userId, userInfo);
             channel?.members.set(member.userId, member);
-            if (_userId == userId) {
+            if (_userId === userId) {
               channel!.me = member;
             }
           }
@@ -207,9 +211,12 @@ export class Pusher {
       }
     });
 
-    this.addListener('onSubscriptionError', async ({ channelName, message, type }) => {
-      args.onSubscriptionError?.(channelName, message, type);
-    });
+    this.addListener(
+      'onSubscriptionError',
+      async ({ channelName, message, type }) => {
+        args.onSubscriptionError?.(channelName, message, type);
+      }
+    );
 
     return PusherWebsocketReactNative.initialize({
       apiKey: args.apiKey,
@@ -236,7 +243,11 @@ export class Pusher {
   async subscribe(args: {
     channelName: string;
     onSubscriptionSucceeded?: (data: any) => void;
-    onSubscriptionError?: (channelName: string, message: string, e: any) => void;
+    onSubscriptionError?: (
+      channelName: string,
+      message: string,
+      e: any
+    ) => void;
     onMemberAdded?: (member: PusherMember) => void;
     onMemberRemoved?: (member: PusherMember) => void;
     onEvent?: (event: PusherEvent) => void;