Skip to content

Commit 4d75e25

Browse files
Allow read_tmy3 to handle 00:00 timestamps (#1494)
* Update read_tmy3 date shift * Add test coverage * Add whatsnew entry * Clean up TMY3 table * Add comments to test files * Fix stickler * Update admonition * Apply changes from kanderso-nrel * Add encoding option to read_tmy3 * Fix stickler * Update pvlib/iotools/tmy.py Co-authored-by: Kevin Anderson <[email protected]> * Remove encoding parameter and add try/except * Fix incorrect parenthesis * Add fbuf.close and first within try/except * Add finally clause * Utilize open and add _parse_tmy3 * Fix stickler Co-authored-by: Kevin Anderson <[email protected]>
1 parent 7348be8 commit 4d75e25

File tree

4 files changed

+8916
-122
lines changed

4 files changed

+8916
-122
lines changed

docs/sphinx/source/whatsnew/v0.9.2.rst

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,15 @@ Bug fixes
2727
where passing localized timezones with large UTC offsets could return
2828
rise/set/transit times for the wrong day in recent versions of ``ephem``
2929
(:issue:`1449`, :pull:`1448`)
30+
* :py:func:`pvlib.iotools.read_tmy3` is now able to accept midnight
31+
timestamps as either 24:00 (which is the standard) as well as 00:00.
32+
Previously 00:00 timestamps would incorrectly be moved one day forward.
33+
(:pull:`1494`)
3034
* :py:func:`pvlib.iotools.get_psm3` now raises a deprecation warning if
3135
the `leap_day` parameter is not specified in a single-year request.
3236
Starting in pvlib 0.11.0 `leap_day` will default to True instead of False.
3337
(:issue:`1481`, :pull:`1511`)
3438

35-
3639
Testing
3740
~~~~~~~
3841
* Switched CI testing provider from Azure to GitHub Actions (:pull:`1306`)
@@ -46,7 +49,6 @@ Documentation
4649
* Add gallery example of simulating rearside irradiance for a fixed-tilt
4750
array with pvfactors (:pull:`1470`)
4851

49-
5052
Benchmarking
5153
~~~~~~~~~~~~~
5254
* Updated version of numba in asv.conf from 0.36.1 to 0.40.0 to solve numba/numpy conflict. (:issue:`1439`, :pull:`1440`)

0 commit comments

Comments
 (0)