Skip to content

implement inverter.pvwatts_multi #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 14, 2020
Merged

implement inverter.pvwatts_multi #1106

merged 6 commits into from
Dec 14, 2020

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Dec 11, 2020 •
edited
Loading

- [x] Closes #xxxx

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Adds inverter.pvwatts_multi to extend inverter.pvwatts to the case of multiple MPP inputs. Discussion here.

kandersolar
kandersolar approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wholmgren wholmgren added this to the 0.8.1 milestone Dec 14, 2020
@cwhanse cwhanse merged commit 7a99b34 into pvlib:master Dec 14, 2020
@cwhanse cwhanse deleted the pvwatts-multi branch December 14, 2020 16:30
@wfvining wfvining mentioned this pull request Dec 17, 2020
Closed
@kandersolar kandersolar mentioned this pull request Dec 28, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar approved these changes

@wholmgren wholmgren wholmgren approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cwhanse @wholmgren @kandersolar