Change deprecated use of .astype() to .view() #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is made as suggested by the pandas FutureWarning to prevent those warnings. See #1261
kandersolar
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
LGTM, thanks @hashstat!
FYI to the other maintainers, looks like there's a handful of places in the tests that need this update as well: https://dev.azure.com/solararbiter/pvlib%20python/_build/results?buildId=5277&view=logs&j=80999419-997d-54cc-7d9e-fafbf8111e17&t=fe7e5fe7-75d4-55e3-99ba-184521a271ef&l=232
| @@ -180,6 +180,8 @@ Bug fixes | |||
| when data time step is not one minute. Error was introduced in v0.8.1. | |||
| (:issue:`1241`, :pull:`1242`) | |||
| * Corrected :py:func:`~pvlib.solarposition.spa_python` to avoid a future warning. (:pull:`1256`) | |||
| * Changed deprecated use of ``.astype()`` to ``.view()`` in :py:mod:`~pvlib.solarposition`. | |||
| (:issue:`1261`, :pull:`1262`) | |||
There was a problem hiding this comment.
Could merge this with the entry above it, nbd though
There was a problem hiding this comment.
Merged as suggested.
|
Thanks @hashstat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made as suggested by the pandas FutureWarning to prevent
those warnings.
See #1261
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).