Skip to content

Miscellaneous sphinx fixes #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 15, 2022
Merged

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Dec 29, 2021

Two things:

  1. The README file has this line:

    Please see the Installation page of the documentation for complete instructions.

    It's not broken now, but will be as soon as we release 0.9.1. I guess we should leave that until we're ready to make the next release?

  2. The only remaining latest links are in the two markdown files in https://github.com/pvlib/pvlib-python/tree/master/.github. I think it makes sense to leave those as latest.

@kandersolar kandersolar added this to the 0.9.1 milestone Dec 29, 2021
@kandersolar
Copy link
Member Author

pytest failures are all test_forecast.py #1364

@kandersolar kandersolar changed the title Clean up broken sphinx links Miscellaneous sphinx fixes Jan 23, 2022
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ad placement looks good.

@cwhanse
Copy link
Member

cwhanse commented Jan 24, 2022

I'm in favor of merging this. I haven't reviewed all the changes so I won't indicate "approve".

As a side note, I think the "Contributing" page is too long and should be organized into a set of pages. Definitely a different issue.

@kandersolar
Copy link
Member Author

Forgot about this. I'll merge tomorrow unless objections are raised.

@kandersolar kandersolar merged commit d6eece8 into pvlib:master Feb 15, 2022
@kandersolar kandersolar deleted the link_cleanup branch February 15, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants