-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Miscellaneous sphinx fixes #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pytest failures are all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ad placement looks good.
I'm in favor of merging this. I haven't reviewed all the changes so I won't indicate "approve". As a side note, I think the "Contributing" page is too long and should be organized into a set of pages. Definitely a different issue. |
Forgot about this. I'll merge tomorrow unless objections are raised. |
Tests addedUpdates entries todocs/sphinx/source/api.rst
for API changes.Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Two things:
The README file has this line:
It's not broken now, but will be as soon as we release 0.9.1. I guess we should leave that until we're ready to make the next release?
The only remaining
latest
links are in the two markdown files in https://github.com/pvlib/pvlib-python/tree/master/.github. I think it makes sense to leave those aslatest
.