Skip to content

Update outdated nbviewer links #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2023
Merged

Update outdated nbviewer links #1726

merged 3 commits into from
May 4, 2023

Conversation

kshitiz305
Copy link

Fixes : #1721
:issue:#1721

  • Closes Broken links #1721
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • [] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the 0.9.6 milestone May 4, 2023
@kandersolar
Copy link
Member

Thanks @kshitiz305, can you make a note in the 0.9.6 what'snew file and list yourself and @langestefan as contributors?

https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/whatsnew/v0.9.6.rst

Fixes : pvlib#1721

Signed-off-by: kshitiz305 <[email protected]>
@kshitiz305
Copy link
Author

I have made changes to the file as requested

@kandersolar kandersolar changed the title Broken links Update outdated nbviewer links May 4, 2023
@kandersolar kandersolar merged commit 06594f9 into pvlib:main May 4, 2023
@kandersolar
Copy link
Member

Thanks @kshitiz305!

@kandersolar kandersolar modified the milestones: 0.9.6, 0.10.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links
2 participants