Skip to content

Removed unused input as shown in issue #2105 #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

JoseMezaMendieta
Copy link
Contributor

@JoseMezaMendieta JoseMezaMendieta commented Aug 7, 2024

  • Closes Unused fixture input in a fixture #2105
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Removed the unused "times" input for the dni_et() function in test_irradiance.py. Since it was unused, it did not impact current tests. No tests added and no comments added since it was just a deletion.

@kandersolar kandersolar added this to the v0.11.1 milestone Aug 7, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kandersolar kandersolar merged commit ee4f218 into pvlib:main Aug 7, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused fixture input in a fixture
3 participants