Skip to content

Commit 7d17c90

Browse files
rwgkcopybara-github
authored andcommitted
Remove #include <pybind11/type_caster_pyobject_ptr.h> from absl_casters.h
While working on pybind/pybind11#4674 I came to realize that this include is not needed here. Note however that the pybind11/cast.h changes under pybind/pybind11#4601 are still needed, therefore pybind11_abseil still requires current pybind11 master. PiperOrigin-RevId: 533182724
1 parent 53f661e commit 7d17c90

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

WORKSPACE

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,15 @@ http_archive(
3333
build_file = "@pybind11_bazel//:pybind11.BUILD",
3434
strip_prefix = "pybind11-master",
3535
urls = ["https://github.com/pybind/pybind11/archive/refs/heads/master.tar.gz"],
36+
# For easy local testing with pybind11 releases:
37+
# * Comment out the 2 lines above.
38+
# * Uncomment and update the 3 lines below.
39+
# * To compute the sha256 string:
40+
# * Download the .tar.gz file (e.g. curl or wget).
41+
# * sha256sum v2.10.4.tar.gz
42+
# strip_prefix = "pybind11-2.10.4",
43+
# sha256 = "832e2f309c57da9c1e6d4542dedd34b24e4192ecb4d62f6f4866a737454c9970",
44+
# urls = ["https://github.com/pybind/pybind11/archive/refs/tags/v2.10.4.tar.gz"],
3645
)
3746

3847
load("@pybind11_bazel//:python_configure.bzl", "python_configure")

pybind11_abseil/absl_casters.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
#include <pybind11/cast.h>
3434
#include <pybind11/pybind11.h>
3535
#include <pybind11/stl.h>
36-
#include <pybind11/type_caster_pyobject_ptr.h>
3736

3837
// Must NOT appear before at least one pybind11 include.
3938
#include <datetime.h> // Python datetime builtin.

0 commit comments

Comments
 (0)