update to PyO3 0.19.0

Author: davidhewitt

Cargo.lock

@@ -26,7 +26,7 @@ include = [
 ]
 
 [dependencies]
-pyo3 = "0.18.2"
+pyo3 = "0.19.0"
 regex = "1.6.0"
 strum = { version = "0.24.1", features = ["derive"] }
 strum_macros = "0.24.3"
@@ -59,9 +59,9 @@ codegen-units = 1
 strip = true
 
 [dev-dependencies]
-pyo3 = { version = "0.18.2", features = ["auto-initialize"] }
+pyo3 = { version = "0.19.0", features = ["auto-initialize"] }
 
 [build-dependencies]
 version_check = "0.9.4"
 # used where logic has to be version/distribution specific, e.g. pypy
-pyo3-build-config = "0.18.2"
+pyo3-build-config = "0.19.0"

Cargo.toml

@@ -153,8 +153,7 @@ impl<'a> Input<'a> for PyAny {
         } else if let Ok(tuple) = self.downcast::<PyTuple>() {
             Ok(PyArgs::new(Some(tuple), None).into())
         } else if let Ok(list) = self.downcast::<PyList>() {
-            let tuple = list_as_tuple(list);
-            Ok(PyArgs::new(Some(tuple), None).into())
+            Ok(PyArgs::new(Some(list.to_tuple()), None).into())
         } else {
             Err(ValError::new(ErrorType::ArgumentsType, self))
         }
@@ -296,7 +295,7 @@ impl<'a> Input<'a> for PyAny {
     }
 
     fn ultra_strict_float(&self) -> ValResult<f64> {
-        if matches!(self.is_instance_of::<PyInt>(), Ok(true)) {
+        if self.is_instance_of::<PyInt>() {
             Err(ValError::new(ErrorType::FloatType, self))
         } else if let Ok(float) = self.extract::<f64>() {
             Ok(float)
@@ -695,12 +694,3 @@ fn is_dict_items_type(v: &PyAny) -> bool {
         .as_ref(py);
     v.is_instance(items_type).unwrap_or(false)
 }
-
-pub fn list_as_tuple(list: &PyList) -> &PyTuple {
-    let py_tuple: Py<PyTuple> = unsafe {
-        let ptr = list.as_ptr();
-        let tuple_ptr = ffi::PyList_AsTuple(ptr);
-        Py::from_owned_ptr(list.py(), tuple_ptr)
-    };
-    py_tuple.into_ref(list.py())
-}

src/input/input_python.rs

@@ -189,7 +189,7 @@ fn on_error(py: Python, err: PyErr, function_name: &str, extra: &Extra) -> PyRes
         }
     } else if let Ok(err) = exception.extract::<PydanticSerializationError>() {
         py_err!(PydanticSerializationError; "{}", err)
-    } else if exception.is_instance_of::<PyRecursionError>().unwrap_or(false) {
+    } else if exception.is_instance_of::<PyRecursionError>() {
         py_err!(PydanticSerializationError; "Error calling function `{}`: RecursionError", function_name)
     } else {
         let new_err = py_error_type!(PydanticSerializationError; "Error calling function `{}`: {}", function_name, err);