add comment with explanation

sydney-runkle · sydney-runkle · commit 038f56cbaf67 · 2024-01-16T18:34:37.000-05:00
diff --git a/tests/validators/test_dataclasses.py b/tests/validators/test_dataclasses.py
@@ -1664,6 +1664,9 @@ def __post_init__(self):
     [
         *init_test_cases,
         # special case - allow override of default, even when init=False, if extra='allow'
+        # TODO: we haven't really decided if this should be allowed or not
+        # currently, it's disallowed in Pydantic to have a model with extra='allow'
+        # and a field with init=False, so this case isn't really possible at the momment
         ({'a': 'hello', 'b': 'bye'}, 'allow', {'a': 'hello', 'b': 'bye'}),
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -1664,6 +1664,9 @@ def __post_init__(self):`
`1664`	`1664`	`[`
`1665`	`1665`	`*init_test_cases,`
`1666`	`1666`	`# special case - allow override of default, even when init=False, if extra='allow'`
	`1667`	`+ # TODO: we haven't really decided if this should be allowed or not`
	`1668`	`+ # currently, it's disallowed in Pydantic to have a model with extra='allow'`
	`1669`	`+ # and a field with init=False, so this case isn't really possible at the momment`
`1667`	`1670`	`({'a': 'hello', 'b': 'bye'}, 'allow', {'a': 'hello', 'b': 'bye'}),`
`1668`	`1671`	`],`
`1669`	`1672`	`)`