Skip to content

Commit 044f437

Browse files
committed
limit windows builds to Rust 1.77 (to keep Windows 7 support)
1 parent 31a5156 commit 044f437

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,9 @@ jobs:
486486
target: ${{ matrix.target }}
487487
manylinux: ${{ matrix.manylinux }}
488488
args: --release --out dist --interpreter ${{ matrix.interpreter || '3.8 3.9 3.10 3.11 3.12 3.13 pypy3.9 pypy3.10' }}
489-
rust-toolchain: stable
489+
# Limit windows builds to 1.77 to keep Windows 7 support.
490+
# FIXME: Unpin when Python 3.8 support is dropped. (3.9 requires Windows 10)
491+
rust-toolchain: ${{ (matrix.os == 'windows' && '1.77') || 'stable' }}
490492
docker-options: -e CI
491493

492494
- run: ${{ (matrix.os == 'windows' && 'dir') || 'ls -lh' }} dist/
@@ -544,8 +546,6 @@ jobs:
544546
# generate self-schema now, so we don't have to do so inside docker in maturin build
545547
- run: python generate_self_schema.py
546548

547-
- run: rustc --version --verbose
548-
549549
- name: build initial wheel
550550
uses: PyO3/maturin-action@v1
551551
with:
@@ -554,7 +554,9 @@ jobs:
554554
--release
555555
--out pgo-wheel
556556
--interpreter ${{ matrix.interpreter }}
557-
rust-toolchain: stable
557+
# Limit windows builds to 1.77 to keep Windows 7 support.
558+
# FIXME: Unpin when Python 3.8 support is dropped. (3.9 requires Windows 10)
559+
rust-toolchain: ${{ (matrix.os == 'windows' && '1.77') || 'stable' }}
558560
docker-options: -e CI
559561
env:
560562
RUSTFLAGS: "-Cprofile-generate=${{ github.workspace }}/profdata"
@@ -582,7 +584,9 @@ jobs:
582584
--release
583585
--out dist
584586
--interpreter ${{ matrix.interpreter }}
585-
rust-toolchain: stable
587+
# Limit windows builds to 1.77 to keep Windows 7 support.
588+
# FIXME: Unpin when Python 3.8 support is dropped. (3.9 requires Windows 10)
589+
rust-toolchain: ${{ (matrix.os == 'windows' && '1.77') || 'stable' }}
586590
docker-options: -e CI
587591
env:
588592
RUSTFLAGS: "-Cprofile-use=${{ github.workspace }}/merged.profdata"

0 commit comments

Comments
 (0)