fix: apply feedback

Author: JeanArhancet

pydantic_core/core_schema.py

@@ -3802,7 +3802,6 @@ def definition_reference_schema(
     'int_from_float',
     'float_type',
     'float_parsing',
-    'float_parsing_size',
     'bytes_type',
     'bytes_too_short',
     'bytes_too_long',

src/errors/types.rs

@@ -181,7 +181,6 @@ pub enum ErrorType {
     // float errors
     FloatType,
     FloatParsing,
-    FloatParsingSize,
     // ---------------------
     // bytes errors
     BytesType,
@@ -503,7 +502,6 @@ impl ErrorType {
             Self::IntParsingSize => "Unable to parse input string as an integer, exceeded maximum size",
             Self::FloatType => "Input should be a valid number",
             Self::FloatParsing => "Input should be a valid number, unable to parse string as a number",
-            Self::FloatParsingSize => "Unable to parse input string as a number, exceeded maximum size",
             Self::BytesType => "Input should be a valid bytes",
             Self::BytesTooShort {..} => "Data should have at least {min_length} bytes",
             Self::BytesTooLong {..} => "Data should have at most {max_length} bytes",

src/input/input_python.rs

@@ -305,8 +305,8 @@ impl<'a> Input<'a> for PyAny {
     fn ultra_strict_float(&'a self) -> ValResult<EitherFloat<'a>> {
         if self.is_instance_of::<PyInt>() {
             Err(ValError::new(ErrorType::FloatType, self))
-        } else if let Ok(float) = self.extract::<f64>() {
-            Ok(EitherFloat::F64(float))
+        } else if self.is_instance_of::<PyFloat>() {
+            Ok(EitherFloat::Py(self))
         } else {
             Err(ValError::new(ErrorType::FloatType, self))
         }

src/input/return_enums.rs

@@ -905,7 +905,7 @@ impl<'a> TryInto<f64> for EitherFloat<'a> {
     fn try_into(self) -> ValResult<'a, f64> {
         match self {
             EitherFloat::F64(f) => Ok(f),
-            EitherFloat::Py(i) => i.extract().map_err(|_| ValError::new(ErrorType::FloatParsingSize, i)),
+            EitherFloat::Py(i) => i.extract().map_err(|_| ValError::new(ErrorType::FloatParsing, i)),
         }
     }
 }

tests/test_errors.py

@@ -233,7 +233,6 @@ def f(input_value, info):
     ('less_than_equal', 'Input should be less than or equal to 42.1', {'le': 42.1}),
     ('float_type', 'Input should be a valid number', None),
     ('float_parsing', 'Input should be a valid number, unable to parse string as a number', None),
-    ('float_parsing_size', 'Unable to parse input string as a number, exceeded maximum size', None),
     ('bytes_type', 'Input should be a valid bytes', None),
     ('bytes_too_short', 'Data should have at least 42 bytes', {'min_length': 42}),
     ('bytes_too_long', 'Data should have at most 42 bytes', {'max_length': 42}),

tests/validators/test_float.py

@@ -10,6 +10,8 @@
 
 from ..conftest import Err, PyAndJson, plain_repr
 
+f64_max = 1.7976931348623157e308
+
 
 @pytest.mark.parametrize(
     'input_value,expected',