Skip to content

Commit 2b915b0

Browse files
committed
use finish() instead of build()
1 parent 5b54998 commit 2b915b0

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/definitions.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ impl<T: Clone + std::fmt::Debug> DefinitionsBuilder<T> {
8989
}
9090

9191
// Consume this Definitions into a vector of items, indexed by each items ReferenceId
92-
pub fn build(self) -> PyResult<Vec<T>> {
92+
pub fn finish(self) -> PyResult<Vec<T>> {
9393
// We need to create a vec of defs according to the order in their ids
9494
let mut defs: Vec<(usize, T)> = Vec::new();
9595
for (reference, def) in self.definitions.into_iter() {

src/serializers/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ impl SchemaSerializer {
4444
let serializer = CombinedSerializer::build(schema.downcast()?, config, &mut definitions_builder)?;
4545
Ok(Self {
4646
serializer,
47-
definitions: definitions_builder.build()?,
47+
definitions: definitions_builder.finish()?,
4848
json_size: 1024,
4949
config: SerializationConfig::from_config(config)?,
5050
})

src/validators/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ impl SchemaValidator {
7777

7878
let mut validator = build_validator(schema, config, &mut definitions_builder)?;
7979
validator.complete(&definitions_builder)?;
80-
let mut definitions = definitions_builder.clone().build()?;
80+
let mut definitions = definitions_builder.clone().finish()?;
8181
for val in definitions.iter_mut() {
8282
val.complete(&definitions_builder)?;
8383
}
@@ -290,7 +290,7 @@ impl<'py> SelfValidator<'py> {
290290
Err(err) => return py_err!("Error building self-schema:\n {}", err),
291291
};
292292
validator.complete(&definitions_builder)?;
293-
let mut definitions = definitions_builder.clone().build()?;
293+
let mut definitions = definitions_builder.clone().finish()?;
294294
for val in definitions.iter_mut() {
295295
val.complete(&definitions_builder)?;
296296
}

0 commit comments

Comments
 (0)