Skip to content

Commit 7c6f326

Browse files
committed
add typing-extensions to pyodide, add comment about V8 bug
1 parent 8dab0c1 commit 7c6f326

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

wasm-preview/README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
# Demonstration of pydantic-core unit tests running in the browser
22

3-
To run tests in your browser, go
4-
[here](https://githubproxy.samuelcolvin.workers.dev/pydantic/pydantic-core/blob/main/wasm-preview/index.html).
3+
To run tests in your browser, go [here](https://githubproxy.samuelcolvin.workers.dev/pydantic/pydantic-core/blob/main/wasm-preview/index.html).
54

6-
To test with a specific version of pydantic-core, add a query parameter `?pydantic_core_version=...` to the URL,
7-
e.g. `?pydantic_core_version=v0.25.0`, defaults to latest release.
5+
To test with a specific version of pydantic-core, add a query parameter `?pydantic_core_version=...` to the URL, e.g. `?pydantic_core_version=v0.25.0`, defaults to latest release.
86

9-
This doesn't work for version of pydantic-core before v0.23.0 as before that we built 3.10 binaries, and pyodide
10-
now rust 3.11.
7+
This doesn't work for version of pydantic-core before v0.23.0 as before that we built 3.10 binaries, and pyodide now rust 3.11.
118

129
If the output appears to stop prematurely, try looking in the developer console for more details.
10+
11+
Tests are currently failing 10-15% of the wait through on Chrome due to a suspected V8 bug, see [pyodide/pyodide#3792](https://github.com/pyodide/pyodide/issues/3792) for more information.

wasm-preview/worker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ async function main() {
9797
setupStreams(FS, pyodide._module.TTY);
9898
FS.mkdir('/test_dir');
9999
FS.chdir('/test_dir');
100-
await pyodide.loadPackage(['micropip', 'pytest', 'pytz']);
100+
await pyodide.loadPackage(['micropip', 'pytest', 'pytz', 'typing-extensions']);
101101
await pyodide.runPythonAsync(python_code, {globals: pyodide.toPy({pydantic_core_version, tests_zip})});
102102
post();
103103
} catch (err) {

0 commit comments

Comments
 (0)