Skip to content

draft: fix pypy windows pgo build #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

davidhewitt
Copy link
Contributor

Change Summary

WIP. Fixing the PyPy build-pgo issues on main.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Jul 9, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 9, 2023

CodSpeed Performance Report

Merging #754 will not alter performances

Comparing dh/pypy-windows-pgo (5fa186a) with main (0b31711)

Summary

✅ 126 untouched benchmarks

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #754 (5fa186a) into main (964066b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   93.64%   93.65%           
=======================================
  Files          99       99           
  Lines       13929    13938    +9     
  Branches       25       25           
=======================================
+ Hits        13044    13053    +9     
  Misses        879      879           
  Partials        6        6           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964066b...5fa186a. Read the comment docs.

@davidhewitt davidhewitt force-pushed the dh/pypy-windows-pgo branch from c0414bd to c6a4adf Compare July 9, 2023 11:24
@davidhewitt
Copy link
Contributor Author

superseded by #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant