Merge pull request #710 from tkanmae/fix-to-netcdf

Fix #709

Author: shoyer

xray/backends/netCDF4_.py

@@ -155,8 +155,7 @@ def _extract_nc4_encoding(variable, raise_on_invalid=False, lsd_okay=True,
             del encoding[k]
 
     if raise_on_invalid:
-        invalid = [k for enc in encoding for k in enc
-                   if k not in valid_encodings]
+        invalid = [k for k in encoding if k not in valid_encodings]
         if invalid:
             raise ValueError('unexpected encoding parameters for %r backend: '
                              ' %r' % (backend, invalid))

xray/test/test_backends.py

@@ -512,6 +512,13 @@ def test_open_encodings(self):
                                        if k in expected['time'].encoding)
                 self.assertDictEqual(actual_encoding, expected['time'].encoding)
 
+    def test_dump_encodings(self):
+        # regression test for #709
+        ds = Dataset({'x': ('y', np.arange(10.0))})
+        kwargs = dict(encoding={'x': {'zlib': True}})
+        with self.roundtrip(ds, save_kwargs=kwargs) as actual:
+            self.assertTrue(actual.x.encoding['zlib'])
+
     def test_dump_and_open_encodings(self):
         # Create a netCDF file with explicit time units
         # and make sure it makes it into the encodings