Skip to content

Commit 77a392d

Browse files
[deprecation] Make 'py_version' required for 'MessageDefinition.may_be_emitted' (#8473)
1 parent 95a82dc commit 77a392d

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

doc/whatsnew/fragments/8473.internal

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Following a deprecation period, the ``py_version`` argument of the
2+
``MessageDefinition.may_be_emitted`` function is now required. The most likely solution
3+
is to use 'linter.config.py_version' if you need to keep using this
4+
function, or to use 'MessageDefinition.is_message_enabled' instead.
5+
6+
Refs #8473

pylint/message/message_definition.py

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from __future__ import annotations
66

77
import sys
8-
import warnings
98
from typing import TYPE_CHECKING, Any
109

1110
from astroid import nodes
@@ -73,23 +72,8 @@ def __repr__(self) -> str:
7372
def __str__(self) -> str:
7473
return f"{repr(self)}:\n{self.msg} {self.description}"
7574

76-
def may_be_emitted(
77-
self,
78-
py_version: tuple[int, ...] | sys._version_info | None = None,
79-
) -> bool:
80-
"""Return True if message may be emitted using the configured py_version."""
81-
if py_version is None:
82-
py_version = sys.version_info
83-
# TODO: 3.0
84-
warnings.warn(
85-
"'py_version' will be a required parameter of "
86-
"'MessageDefinition.may_be_emitted' in pylint 3.0. The most likely "
87-
"solution is to use 'linter.config.py_version' if you need to keep "
88-
"using this function, or to use 'MessageDefinition.is_message_enabled'"
89-
" instead.",
90-
DeprecationWarning,
91-
stacklevel=2,
92-
)
75+
def may_be_emitted(self, py_version: tuple[int, ...] | sys._version_info) -> bool:
76+
"""May the message be emitted using the configured py_version?"""
9377
if self.minversion is not None and self.minversion > py_version:
9478
return False
9579
if self.maxversion is not None and self.maxversion <= py_version:

0 commit comments

Comments
 (0)