Raise NotImplementedError in Group.__init__

Author: brandonwillard

pymc3/variational/opvi.py

@@ -63,6 +63,7 @@
 from pymc3.model import modelcontext
 from pymc3.util import get_default_varnames, get_transformed
 from pymc3.variational.updates import adagrad_window
+from pymc3.vartypes import discrete_types
 
 __all__ = ["ObjectiveFunction", "Operator", "TestFunction", "Group", "Approximation"]
 
@@ -831,6 +832,9 @@ def __init__(
         options=None,
         **kwargs,
     ):
+        # XXX: Needs to be refactored for v4
+        raise NotImplementedError("This class needs to be refactored for v4")
+
         if local and not self.supports_batched:
             raise LocalGroupError("%s does not support local groups" % self.__class__)
         if local and rowwise:
@@ -957,7 +961,7 @@ def __init_group__(self, group):
         # self.ordering = ArrayOrdering([])
         self.replacements = dict()
         for var in self.group:
-            if isinstance(var.distribution, pm.Discrete):
+            if var.type.numpy_dtype.name in discrete_types:
                 raise ParametrizationError(f"Discrete variables are not supported by VI: {var}")
             begin = self.ddim
             if self.batched: