use np.shape

Author: MarcoGorelli

pymc3/sampling.py

@@ -14,7 +14,7 @@
 
 """Functions for MCMC sampling."""
 
-from typing import Dict, List, Optional, cast, Union, Any, Tuple
+from typing import Dict, List, Optional, cast, Union, Any
 from typing import Iterable as TIterable
 from collections.abc import Iterable
 from collections import defaultdict
@@ -1573,10 +1573,7 @@ def insert(self, k: str, v, idx: int):
         ids: int
             The index of the sample we are inserting into the trace.
         """
-        if hasattr(v, "shape"):
-            value_shape: Tuple[int, ...] = tuple(v.shape)
-        else:
-            value_shape = ()
+        value_shape = np.shape(v)
 
         # initialize if necessary
         if k not in self.trace_dict:

pymc3/tests/test_sampling.py

@@ -213,6 +213,7 @@ def test_return_inferencedata(self, monkeypatch):
             monkeypatch.setattr("pymc3.__version__", "3.10")
             with pytest.warns(FutureWarning, match="pass return_inferencedata"):
                 result = pm.sample(**kwargs)
+        pass
 
     @pytest.mark.parametrize("cores", [1, 2])
     def test_sampler_stat_tune(self, cores):