Skip to content

[CU-a73n08, Docs] Glossary - Dispersion #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 14, 2021

Conversation

CloudChaoszero
Copy link
Contributor

@CloudChaoszero CloudChaoszero commented Sep 5, 2021

Description

  • Add "Dispersion"-related definitions in PyMC glossary
  • [Optional]: Creating template for adding terms into Glossary

CU-5t5y0p Glossary

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #4984 (f6b5650) into main (65abc6f) will increase coverage by 17.18%.
The diff coverage is n/a.

❗ Current head f6b5650 differs from pull request most recent head cea56e7. Consider uploading reports for the commit cea56e7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4984       +/-   ##
===========================================
+ Coverage   61.11%   78.29%   +17.18%     
===========================================
  Files         130      129        -1     
  Lines       24461    24396       -65     
===========================================
+ Hits        14950    19102     +4152     
+ Misses       9511     5294     -4217     
Impacted Files Coverage Δ
pymc/backends/report.py 87.41% <0.00%> (-2.10%) ⬇️
pymc/parallel_sampling.py 86.33% <0.00%> (-1.00%) ⬇️
pymc/tests/test_step.py 48.63% <0.00%> (-0.96%) ⬇️
pymc/tests/test_idata_conversion.py 96.20% <0.00%> (-0.20%) ⬇️
pymc/__init__.py 96.00% <0.00%> (-0.08%) ⬇️
pymc/tests/test_model.py 99.11% <0.00%> (-0.04%) ⬇️
pymc/tests/test_sampling.py 97.29% <0.00%> (ø)
pymc/step_methods/__init__.py 100.00% <0.00%> (ø)
pymc/distributions/__init__.py 100.00% <0.00%> (ø)
pymc/bart/pgbart.py
... and 56 more

@CloudChaoszero CloudChaoszero changed the title [Docs Team] Glossary - Dispersion [CU-a73n08, Docs] Glossary - Dispersion Sep 6, 2021
Copy link
Contributor

@martinacantaro martinacantaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Underdispersion entry links to the Overdispersion wikipedia page.

I don't think it's necessary to write the definitions inside quotation marks.

For the dispersion definition, I would try to clarify what 'streched' and 'squeezed' mean, as it is a bit ambiguous

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these definitions (especially also looking at the issue and other PRs) are quite complicated and many talks have been given and book chapters written about them, so I think it is very important to be generous with links and references.

I have added a suggestion to link to "dispersion" from the definition of overdispersion (same should be done for underdispersion). I think many definitions will need to refer to other terms.

It might also be a good idea to add some references or seealso links. We can discuss that during the meeting, but as this is mostly oriented at newcomers, we could recommend a section of 1-2 books to dive deeper into that term/area which would link the resources repo with this one much more

@martinacantaro
Copy link
Contributor

Task linked: CU-5t5y0p Glossary

@CloudChaoszero
Copy link
Contributor Author

Sounds great @martinacantaro. I also added Oriol's recommendation

Copy link
Contributor

@martinacantaro martinacantaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Solved some conflicts, I'm fine with merging it now and creating some issues to resolve later if there's anything we want to improve upon @OriolAbril . I'd suggest moving links out of the definition titles in the future.

(Edited this issue so although this is categorized "request for changes" type of review, I'm not requesting any changes).

@@ -3,6 +3,7 @@
A glossary of common terms used throughout the PyMC3 documentation and examples.

:::::{glossary}

[Term with external reference](https://www.youtube.com/watch?v=6dc7JgR8eI0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section

@martinacantaro
Copy link
Contributor

/pre-commit-run

@CloudChaoszero
Copy link
Contributor Author

@martinacantaro are there any additional edits for this? I saw you made some great commits, appreciate it!

@OriolAbril OriolAbril merged commit 38a9e1f into pymc-devs:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants