-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[CU-a73n08, Docs] Glossary - Dispersion #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4984 +/- ##
===========================================
+ Coverage 61.11% 78.29% +17.18%
===========================================
Files 130 129 -1
Lines 24461 24396 -65
===========================================
+ Hits 14950 19102 +4152
+ Misses 9511 5294 -4217
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Underdispersion entry links to the Overdispersion wikipedia page.
I don't think it's necessary to write the definitions inside quotation marks.
For the dispersion definition, I would try to clarify what 'streched' and 'squeezed' mean, as it is a bit ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of these definitions (especially also looking at the issue and other PRs) are quite complicated and many talks have been given and book chapters written about them, so I think it is very important to be generous with links and references.
I have added a suggestion to link to "dispersion" from the definition of overdispersion (same should be done for underdispersion). I think many definitions will need to refer to other terms.
It might also be a good idea to add some references or seealso links. We can discuss that during the meeting, but as this is mostly oriented at newcomers, we could recommend a section of 1-2 books to dive deeper into that term/area which would link the resources repo with this one much more
Task linked: CU-5t5y0p Glossary |
Sounds great @martinacantaro. I also added Oriol's recommendation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Solved some conflicts, I'm fine with merging it now and creating some issues to resolve later if there's anything we want to improve upon @OriolAbril . I'd suggest moving links out of the definition titles in the future.
(Edited this issue so although this is categorized "request for changes" type of review, I'm not requesting any changes).
docs/source/glossary.md
Outdated
@@ -3,6 +3,7 @@ | |||
A glossary of common terms used throughout the PyMC3 documentation and examples. | |||
|
|||
:::::{glossary} | |||
|
|||
[Term with external reference](https://www.youtube.com/watch?v=6dc7JgR8eI0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this section
/pre-commit-run |
@martinacantaro are there any additional edits for this? I saw you made some great commits, appreciate it! |
Description
CU-5t5y0p Glossary