BART: make linear response more robust and fix bug with predictions #5080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5080 +/- ##
==========================================
- Coverage 78.21% 78.14% -0.08%
==========================================
Files 131 131
Lines 24523 24532 +9
==========================================
- Hits 19181 19170 -11
- Misses 5342 5362 +20
|
twiecki
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am also reverting back the default response to "constant", even when BART is still experimental and "mix" or "linear" seems to provide a better fit, maybe better to be a little bit more conservative until we have results for more experiments.