Minor improvements to GitPod #6618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
Mar 24, 2023
|
Hmm, any idea why the tests are blocked? |
|
@Armavica may have an idea? |
|
I would say that it is because none of the files modified match any of the patterns listed here: https://github.com/pymc-devs/pymc/blob/main/.github/workflows/tests.yml#L4-L12 |
|
Ah, so we should adjust to make the tests conditionally required (if possible) or ensure required tests run regardless. For now, is there any admin who could override? |
You mean to merge? |
Yes |
|
Thanks @ricardoV94! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the dev container base image, and also run the initial Conda installs and pre-commit installs in the background.
What is this PR about?
...
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance