Skip to content

Commit 851128f

Browse files
author
Ian Schweer
committed
Add elemwise test
1 parent ed71acb commit 851128f

File tree

2 files changed

+32
-1
lines changed

2 files changed

+32
-1
lines changed

pytensor/link/pytorch/dispatch/scalar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def scalar_loop(steps, *start_and_constants):
6666
done = True
6767
for _ in range(steps):
6868
*carry, done = update(*carry, *constants)
69-
if done:
69+
if torch.any(done):
7070
break
7171
if len(node.outputs) == 2:
7272
return carry[0], done

tests/link/pytorch/test_basic.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from pytensor.scalar import float64, int64
2121
from pytensor.scalar.loop import ScalarLoop
2222
from pytensor.tensor import alloc, arange, as_tensor, empty, eye
23+
from pytensor.tensor.elemwise import Elemwise
2324
from pytensor.tensor.type import matrices, matrix, scalar, vector
2425

2526

@@ -407,3 +408,33 @@ def test_ScalarLoop_while():
407408
):
408409
np.testing.assert_allclose(res[0], np.array(expected[0]))
409410
np.testing.assert_allclose(res[1], np.array(expected[1]))
411+
412+
def test_pytorch_OpFromGraph():
413+
x, y, z = matrices("xyz")
414+
ofg_1 = OpFromGraph([x, y], [x + y])
415+
ofg_2 = OpFromGraph([x, y], [x * y, x - y])
416+
417+
o1, o2 = ofg_2(y, z)
418+
out = ofg_1(x, o1) + o2
419+
420+
xv = np.ones((2, 2), dtype=config.floatX)
421+
yv = np.ones((2, 2), dtype=config.floatX) * 3
422+
zv = np.ones((2, 2), dtype=config.floatX) * 5
423+
424+
f = FunctionGraph([x, y, z], [out])
425+
compare_pytorch_and_py(f, [xv, yv, zv])
426+
427+
428+
def test_ScalarLoop_Elemwise():
429+
n_steps = int64("n_steps")
430+
x0 = float64("x0")
431+
x = x0 * 2
432+
until = x >= 10
433+
434+
op = ScalarLoop(init=[x0], update=[x], until=until)
435+
fn = function([n_steps, x0], Elemwise(op)(n_steps, x0), mode=pytorch_mode)
436+
437+
states, dones = fn(10, np.array(range(5)))
438+
439+
np.testing.assert_allclose(states, [0, 4, 8, 12, 16])
440+
np.testing.assert_allclose(dones, [False, False, False, True, True])

0 commit comments

Comments
 (0)