Centralize warning about always enabled features

Author: sbidoul

src/pip/_internal/cli/base_command.py

@@ -122,6 +122,15 @@ def _main(self, args: List[str]) -> int:
             user_log_file=options.log,
         )
 
+        always_enabled_features = set(options.features_enabled) & set(
+            cmdoptions.ALWAYS_ENABLED_FEATURES
+        )
+        if always_enabled_features:
+            logger.warning(
+                "The following features are always enabled: %s. ",
+                ", ".join(sorted(always_enabled_features)),
+            )
+
         # TODO: Try to get these passing down from the command?
         #       without resorting to os.environ to hold these.
         #       This also affects isolated builds and it should.

src/pip/_internal/cli/cmdoptions.py

@@ -994,6 +994,11 @@ def check_list_path_option(options: Values) -> None:
 )
 
 
+# Features that are now always on. A warning is printed if they are used.
+ALWAYS_ENABLED_FEATURES = [
+    "no-binary-enable-wheel-cache",  # always on since 23.1
+]
+
 use_new_feature: Callable[..., Option] = partial(
     Option,
     "--use-feature",
@@ -1004,8 +1009,8 @@ def check_list_path_option(options: Values) -> None:
     choices=[
         "fast-deps",
         "truststore",
-        "no-binary-enable-wheel-cache",  # now always on
-    ],
+    ]
+    + ALWAYS_ENABLED_FEATURES,
     help="Enable new functionality, that may be backward incompatible.",
 )
 

src/pip/_internal/commands/install.py

@@ -343,9 +343,6 @@ def run(self, options: Values, args: List[str]) -> int:
             reqs = self.get_requirements(args, options, finder, session)
             check_legacy_setup_py_options(options, reqs)
 
-            if "no-binary-enable-wheel-cache" in options.features_enabled:
-                logger.warning("no-binary-enable-wheel-cache is now active by default.")
-
             wheel_cache = WheelCache(options.cache_dir)
 
             # Only when installing is it permitted to use PEP 660.

src/pip/_internal/commands/wheel.py

@@ -120,9 +120,6 @@ def run(self, options: Values, args: List[str]) -> int:
         reqs = self.get_requirements(args, options, finder, session)
         check_legacy_setup_py_options(options, reqs)
 
-        if "no-binary-enable-wheel-cache" in options.features_enabled:
-            logger.warning("no-binary-enable-wheel-cache is now active by default.")
-
         wheel_cache = WheelCache(options.cache_dir)
 
         preparer = self.make_requirement_preparer(