Skip to content

Commit 2bd13ae

Browse files
committed
Skip pytest-cov in setup.cfg for PyPy
Instead of disabling coverage in the GitHub workflow it might be easier to just not install it in the test environment.
1 parent ad29c0a commit 2bd13ae

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ jobs:
3838
- name: Install tox
3939
run: |
4040
python -m pip install tox
41-
- name: Disable coverage on PyPy
42-
# Coverage seems to slow things down on PyPy (ubuntu is still OK-ish)
43-
if: contains(matrix.python, 'pypy') && matrix.platform != 'ubuntu-latest'
44-
shell: bash
45-
run: echo 'PYTEST_ADDOPTS=-p no:cov' >> $GITHUB_ENV
4641
- name: Run tests
4742
run: tox -- --cov-report xml
4843
- name: Publish coverage

setup.cfg

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ testing =
4646
pytest-black >= 0.3.7; \
4747
# workaround for jaraco/skeleton#22
4848
python_implementation != "PyPy"
49-
pytest-cov
49+
pytest-cov; \
50+
# coverage seems to make PyPy extremely slow
51+
python_implementation != "PyPy"
5052
pytest-mypy >= 0.9.1; \
5153
# workaround for jaraco/skeleton#22
5254
python_implementation != "PyPy"

0 commit comments

Comments
 (0)