Merge pull request #2852 from barneygale/fix-2794

Ignore directories in PATH that can't be opened

Author: gaborbernat

docs/changelog/2794.bugfix.rst

@@ -0,0 +1 @@
+Ignore unreadable directories in ``PATH``.

src/virtualenv/discovery/builtin.py

@@ -171,7 +171,7 @@ def get_paths(env: Mapping[str, str]) -> Generator[Path, None, None]:
     if path:
         for p in map(Path, path.split(os.pathsep)):
             with suppress(OSError):
-                if p.exists():
+                if next(p.iterdir(), None):
                     yield p
 
 

tests/unit/discovery/test_discovery.py

@@ -63,6 +63,11 @@ def test_discovery_via_path_not_found(tmp_path, monkeypatch):
 def test_discovery_via_path_in_nonbrowseable_directory(tmp_path, monkeypatch):
     bad_perm = tmp_path / "bad_perm"
     bad_perm.mkdir(mode=0o000)
+    # path entry is unreadable
+    monkeypatch.setenv("PATH", str(bad_perm))
+    interpreter = get_interpreter(uuid4().hex, [])
+    assert interpreter is None
+    # path entry parent is unreadable
     monkeypatch.setenv("PATH", str(bad_perm / "bin"))
     interpreter = get_interpreter(uuid4().hex, [])
     assert interpreter is None