Skip to content

Commit dbedec5

Browse files
pawelszramowskiPaweł Szramowski
and
Paweł Szramowski
authored
Do not turn echo off for subsequent commands in batch activators (#2411) (#2412)
Co-authored-by: Paweł Szramowski <[email protected]>
1 parent d9575ee commit dbedec5

File tree

3 files changed

+35
-37
lines changed

3 files changed

+35
-37
lines changed

docs/changelog/2411.bugfix.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Do not turn echo off for subsequent commands in batch activators
2+
(``activate.bat`` and ``deactivate.bat``) - by :user:`pawelszramowski`.
Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,37 @@
1-
@echo off
1+
@set "VIRTUAL_ENV=__VIRTUAL_ENV__"
22

3-
set "VIRTUAL_ENV=__VIRTUAL_ENV__"
4-
5-
if defined _OLD_VIRTUAL_PROMPT (
6-
set "PROMPT=%_OLD_VIRTUAL_PROMPT%"
3+
@if defined _OLD_VIRTUAL_PROMPT (
4+
@set "PROMPT=%_OLD_VIRTUAL_PROMPT%"
75
) else (
8-
if not defined PROMPT (
9-
set "PROMPT=$P$G"
6+
@if not defined PROMPT (
7+
@set "PROMPT=$P$G"
108
)
11-
if not defined VIRTUAL_ENV_DISABLE_PROMPT (
12-
set "_OLD_VIRTUAL_PROMPT=%PROMPT%"
9+
@if not defined VIRTUAL_ENV_DISABLE_PROMPT (
10+
@set "_OLD_VIRTUAL_PROMPT=%PROMPT%"
1311
)
1412
)
15-
if not defined VIRTUAL_ENV_DISABLE_PROMPT (
16-
if "__VIRTUAL_PROMPT__" NEQ "" (
17-
set "PROMPT=(__VIRTUAL_PROMPT__) %PROMPT%"
13+
@if not defined VIRTUAL_ENV_DISABLE_PROMPT (
14+
@if "__VIRTUAL_PROMPT__" NEQ "" (
15+
@set "PROMPT=(__VIRTUAL_PROMPT__) %PROMPT%"
1816
) else (
19-
for %%d in ("%VIRTUAL_ENV%") do set "PROMPT=(%%~nxd) %PROMPT%"
17+
@for %%d in ("%VIRTUAL_ENV%") do @set "PROMPT=(%%~nxd) %PROMPT%"
2018
)
2119
)
2220

23-
REM Don't use () to avoid problems with them in %PATH%
24-
if defined _OLD_VIRTUAL_PYTHONHOME goto ENDIFVHOME
25-
set "_OLD_VIRTUAL_PYTHONHOME=%PYTHONHOME%"
21+
@REM Don't use () to avoid problems with them in %PATH%
22+
@if defined _OLD_VIRTUAL_PYTHONHOME @goto ENDIFVHOME
23+
@set "_OLD_VIRTUAL_PYTHONHOME=%PYTHONHOME%"
2624
:ENDIFVHOME
2725

28-
set PYTHONHOME=
26+
@set PYTHONHOME=
2927

30-
REM if defined _OLD_VIRTUAL_PATH (
31-
if not defined _OLD_VIRTUAL_PATH goto ENDIFVPATH1
32-
set "PATH=%_OLD_VIRTUAL_PATH%"
28+
@REM if defined _OLD_VIRTUAL_PATH (
29+
@if not defined _OLD_VIRTUAL_PATH @goto ENDIFVPATH1
30+
@set "PATH=%_OLD_VIRTUAL_PATH%"
3331
:ENDIFVPATH1
34-
REM ) else (
35-
if defined _OLD_VIRTUAL_PATH goto ENDIFVPATH2
36-
set "_OLD_VIRTUAL_PATH=%PATH%"
32+
@REM ) else (
33+
@if defined _OLD_VIRTUAL_PATH @goto ENDIFVPATH2
34+
@set "_OLD_VIRTUAL_PATH=%PATH%"
3735
:ENDIFVPATH2
3836

39-
set "PATH=%VIRTUAL_ENV%\__BIN_NAME__;%PATH%"
37+
@set "PATH=%VIRTUAL_ENV%\__BIN_NAME__;%PATH%"
Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
1-
@echo off
1+
@set VIRTUAL_ENV=
22

3-
set VIRTUAL_ENV=
4-
5-
REM Don't use () to avoid problems with them in %PATH%
6-
if not defined _OLD_VIRTUAL_PROMPT goto ENDIFVPROMPT
7-
set "PROMPT=%_OLD_VIRTUAL_PROMPT%"
8-
set _OLD_VIRTUAL_PROMPT=
3+
@REM Don't use () to avoid problems with them in %PATH%
4+
@if not defined _OLD_VIRTUAL_PROMPT @goto ENDIFVPROMPT
5+
@set "PROMPT=%_OLD_VIRTUAL_PROMPT%"
6+
@set _OLD_VIRTUAL_PROMPT=
97
:ENDIFVPROMPT
108

11-
if not defined _OLD_VIRTUAL_PYTHONHOME goto ENDIFVHOME
12-
set "PYTHONHOME=%_OLD_VIRTUAL_PYTHONHOME%"
13-
set _OLD_VIRTUAL_PYTHONHOME=
9+
@if not defined _OLD_VIRTUAL_PYTHONHOME @goto ENDIFVHOME
10+
@set "PYTHONHOME=%_OLD_VIRTUAL_PYTHONHOME%"
11+
@set _OLD_VIRTUAL_PYTHONHOME=
1412
:ENDIFVHOME
1513

16-
if not defined _OLD_VIRTUAL_PATH goto ENDIFVPATH
17-
set "PATH=%_OLD_VIRTUAL_PATH%"
18-
set _OLD_VIRTUAL_PATH=
14+
@if not defined _OLD_VIRTUAL_PATH @goto ENDIFVPATH
15+
@set "PATH=%_OLD_VIRTUAL_PATH%"
16+
@set _OLD_VIRTUAL_PATH=
1917
:ENDIFVPATH

0 commit comments

Comments
 (0)