Skip to content

Commit 99b38ff

Browse files
nedbationelmc
authored andcommitted
Report on failed workers before trying to report their data
cov.report() will fail, preventing us from mentioning the failed workers, so do the failed workers first.
1 parent 32744a5 commit 99b38ff

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/pytest_cov/engine.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,14 @@ def summary(self, stream):
114114
for node_desc in sorted(self.node_descs):
115115
self.sep(stream, ' ', '%s' % node_desc)
116116

117+
# Report on any failed workers.
118+
if self.failed_workers:
119+
self.sep(stream, '-', 'coverage: failed workers')
120+
stream.write('The following workers failed to return coverage data, '
121+
'ensure that pytest-cov is installed on these workers.\n')
122+
for node in self.failed_workers:
123+
stream.write('%s\n' % node.gateway.id)
124+
117125
# Produce terminal report if wanted.
118126
if any(x in self.cov_report for x in ['term', 'term-missing']):
119127
options = {
@@ -157,14 +165,6 @@ def summary(self, stream):
157165
self.cov.xml_report(ignore_errors=True, outfile=output)
158166
stream.write('Coverage XML written to file %s\n' % (self.cov.config.xml_output if output is None else output))
159167

160-
# Report on any failed workers.
161-
if self.failed_workers:
162-
self.sep(stream, '-', 'coverage: failed workers')
163-
stream.write('The following workers failed to return coverage data, '
164-
'ensure that pytest-cov is installed on these workers.\n')
165-
for node in self.failed_workers:
166-
stream.write('%s\n' % node.gateway.id)
167-
168168
return total
169169

170170

0 commit comments

Comments
 (0)