[mypy] Remove useless noqa, add noqa for new false positives

Author: Pierre-Sassoulas

src/_pytest/_io/pprint.py

@@ -111,15 +111,15 @@ def _format(
             p(self, object, stream, indent, allowance, context, level + 1)
             context.remove(objid)
         elif (
-            _dataclasses.is_dataclass(object)  # type:ignore[unreachable]
+            _dataclasses.is_dataclass(object)
             and not isinstance(object, type)
-            and object.__dataclass_params__.repr
+            and object.__dataclass_params__.repr  # type:ignore[attr-defined]
             and
             # Check dataclass has generated repr method.
             hasattr(object.__repr__, "__wrapped__")
             and "__create_fn__" in object.__repr__.__wrapped__.__qualname__
         ):
-            context.add(objid)  # type:ignore[unreachable]
+            context.add(objid)
             self._pprint_dataclass(
                 object, stream, indent, allowance, context, level + 1
             )

src/_pytest/capture.py

@@ -177,7 +177,7 @@ def name(self) -> str:
     def mode(self) -> str:
         # TextIOWrapper doesn't expose a mode, but at least some of our
         # tests check it.
-        return self.buffer.mode.replace("b", "")
+        return self.buffer.mode.replace("b", "")  # type: ignore[no-any-return,attr-defined]
 
 
 class CaptureIO(io.TextIOWrapper):
@@ -550,7 +550,7 @@ def snap(self) -> bytes:
         res = self.tmpfile.buffer.read()
         self.tmpfile.seek(0)
         self.tmpfile.truncate()
-        return res
+        return res  # type: ignore[return-value]
 
     def writeorg(self, data: bytes) -> None:
         """Write to original file descriptor."""

testing/test_runner.py

@@ -137,8 +137,8 @@ def raiser(exc):
             ss.teardown_exact(None)
         mod, func = e.value.exceptions
         assert isinstance(mod, KeyError)
-        assert isinstance(func.exceptions[0], TypeError)  # type: ignore
-        assert isinstance(func.exceptions[1], ValueError)  # type: ignore
+        assert isinstance(func.exceptions[0], TypeError)
+        assert isinstance(func.exceptions[1], ValueError)
 
     def test_cached_exception_doesnt_get_longer(self, pytester: Pytester) -> None:
         """Regression test for #12204 (the "BTW" case)."""