Skip to content

Commit f732775

Browse files
bluetechblueyed
authored andcommitted
ci: twisted and oldattrs tox envs are now incompatible, don't run them together
twisted started to use `attr.s(eq)` argument which was added recently, so it fails with oldattrs. One of the CI jobs ran twisted and oldattrs together, so it started to fail. Move the twisted code to be covered by another job, and remove it from the job with the oldattrs. (cherry picked from commit 2cc3227)
1 parent ee1950a commit f732775

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,15 @@ jobs:
6262
- name: "windows-py37"
6363
python: "3.7"
6464
os: windows-latest
65-
tox_env: "py37-twisted-numpy"
65+
tox_env: "py37-numpy"
6666
- name: "windows-py37-pluggy"
6767
python: "3.7"
6868
os: windows-latest
6969
tox_env: "py37-pluggymaster-xdist"
7070
- name: "windows-py38"
7171
python: "3.8"
7272
os: windows-latest
73-
tox_env: "py38"
73+
tox_env: "py38-twisted"
7474
use_coverage: true
7575

7676
- name: "ubuntu-py35"
@@ -84,7 +84,7 @@ jobs:
8484
- name: "ubuntu-py37"
8585
python: "3.7"
8686
os: ubuntu-latest
87-
tox_env: "py37-lsof-numpy-oldattrs-pexpect-twisted"
87+
tox_env: "py37-lsof-numpy-oldattrs-pexpect"
8888
use_coverage: true
8989
- name: "ubuntu-py37-pluggy"
9090
python: "3.7"

0 commit comments

Comments
 (0)