Introduced a hardcoded list of project to include as plugins beyond those found by their names. #11077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose found by their names.
The-Compiler
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
Seems fine to me! However I'd recommend not including the changes to the doc in your PR, to avoid it conflicting with e.g. #11076.
|
Wonderful! There I reverted the changes to the generated doc. So this would be ready to land? Thanks! |
bluetech
approved these changes
Jun 6, 2023
|
I triggered a manual run after merging, the PR is #11086. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of question #11066.
No doc updates are included as this is a script to be run by pytest's devs. It seems to not have tests either, but checked this to work OK IRL.
For the same reasons explained above, I didn't touch the changelog or included myself in AUTHORS file.