Skip to content

main: change pkg_roots to work with Paths instead of string paths #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2023
Merged

main: change pkg_roots to work with Paths instead of string paths #11078

merged 1 commit into from
Jun 4, 2023

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Jun 4, 2023

  • Works better on Windows (case sensitivity)
  • Simpler code

@bluetech
main: change pkg_roots to work with Paths instead of string paths
313b614 
- Works better on Windows (case sensitivity)
- Simpler code
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change, thanks

@bluetech bluetech merged commit e1204e1 into pytest-dev:main Jun 4, 2023
@bluetech bluetech deleted the pkg-roots-path branch June 4, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluetech @RonnyPfannschmidt