Skip to content

Fix typos discovered by codespell #12769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 3, 2024

pyproject.toml

[tool.codespell]
ignore-words-list = "afile,asser,assertio,feld,hove,ned,noes,notin,paramete,parth,socio-economic,tesults,varius,wil"
skip = "*/plugin_list.rst"
write-changes = true

% codespell

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we add a hook to consistently fix the plugin list we need to ignore it as it's getting regenerated from you data

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Sep 3, 2024
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nicoddemus nicoddemus enabled auto-merge (squash) September 3, 2024 20:08
@nicoddemus nicoddemus merged commit 09e386e into pytest-dev:main Sep 3, 2024
29 checks passed
Copy link

patchback bot commented Sep 3, 2024

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/09e386e3e0df5a58ef9ab4f8e43f55c650633be7/pr-12769

Backported as #12774

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 3, 2024
@cclauss cclauss deleted the codespell branch September 3, 2024 20:30
nicoddemus pushed a commit that referenced this pull request Sep 3, 2024
(cherry picked from commit 09e386e)

Co-authored-by: Christian Clauss <[email protected]>
@jayaddison
Copy link
Contributor

Utterly pedantic nitpick: I think socio-economic might no longer required in the ignore-list (with codespell v2.4.1). Noticed during version comparison / upgrade preparation from 8.3.5...8.4.0.

@cclauss
Copy link
Contributor Author

cclauss commented Jun 4, 2025

@jayaddison Please make a PR to remove socio-economic here

ignore-words-list = "afile,asend,asser,assertio,feld,hove,ned,noes,notin,paramete,parth,socio-economic,tesults,varius,wil"

If the tests pass, then I would approve that PR.

@jayaddison
Copy link
Contributor

Thank you @cclauss; will do, after re-testing this slightly anxiously to make absolutely certain my previous findings were correct!

@cclauss
Copy link
Contributor Author

cclauss commented Jun 4, 2025

Locally, you can make the change and then run pre-commit run codespell --all-fiiles.

If pre-commit is not found, you can
uv tool run pre-commit run codespell --all-fiiles --or--
pipx run pre-commit run codespell --all-fiiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants