Skip to content

Update talks/trainings page #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Aug 18, 2020

  • Remove past webinar
  • Add new open training
  • Add some talks/webinars by Oliver Bestwalter and by me - I'm sure there have been more talks than those, but I don't have the time to go through years of conferences, so I just added the ones I remember
  • Remove some stale link targets

Also, what do you think about moving the "Next Open Trainings" sidebar from the talks page to the main page? Right now it's quite hard to find the talks/tutorials page (and the training announcement) because it's also not part of the sidebar menu yet (I think it was with the old theme?).

IMHO it'd be nice to show it on the main page instead (since it's often only around for a couple of weeks/months anyways) to give those trainings a bit more visiblity - but since I'm probably the main person benefiting from that kind of thing that's not a decision I want to take alone. What do others think?

- Remove past webinar
- Add new open training
- Add some talks/webinars by Oliver Bestwalter and by me
- Remove some stale link targets
@nicoddemus
Copy link
Member

IMHO it'd be nice to show it on the main page instead (since it's often only around for a couple of weeks/months anyways) to give those trainings a bit more visiblity - but since I'm probably the main person benefiting from that kind of thing that's not a decision I want to take alone. What do others think?

I agree, go for it. More visibility benefits everyone.

In fact we could consider using the pytest twitter account to announce those talks too, for more visibility? cc @hackebrot @pfctdayelise

@The-Compiler
Copy link
Member Author

I pushed a commit to move the block to the main page. Here's how it looks:

image

Not exactly optimal, but I haven't found a way to customize this without having to fork the Pallets Sphinx theme. Given that it'll get smaller in three weeks (when the first training is over) I'm okay with that, unless someone objects. Alternatively, I guess we could add some extra text to the first paragraph of the page if someone can think of something useful.

In fact we could consider using the pytest twitter account to announce those talks too, for more visibility? cc @hackebrot @pfctdayelise

I do have access to the Twitter account as well, and I do sometimes use it for shamless self promotion already. Will do the same for the Python Academy training as well, as I think it's fair to assume that its followers might be interested in such a thing.

@nicoddemus
Copy link
Member

(Btw we can see the preview now thanks to read the docs: https://pytest--7661.org.readthedocs.build/en/7661/)

Alternatively, I guess we could add some extra text to the first paragraph of the page if someone can think of something useful.

Hmm perhaps removing the helps you write better programs from the title would make it look better already?

@The-Compiler
Copy link
Member Author

Hmm perhaps removing the helps you write better programs from the title would make it look better already?

I think that'd make it worse, because it increases the big space between "An example of a simple test:" and the source (which is the main thing I'm worried about).

@nicoddemus
Copy link
Member

I think that'd make it worse, because it increases the big space between "An example of a simple test:" and the source (which is the main thing I'm worried about).

Oh I see, I was more worried about the title that got a bit munched in there, but I don't mind it too much either. 👍

@The-Compiler
Copy link
Member Author

Taking the freedom to merge this given that it's been approved and nobody objects - the sign-up for the workshop in September will close on 31st, so I'll open another PR then to remove the first line, which will hopefully improve how things look.

@The-Compiler The-Compiler merged commit 00996ad into pytest-dev:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants