Ignore dotfiles when collecting schemas.

Prevents errors if e.g. a user on macOS has opened the schema
directory in Finder and thereby had a .DS_Store file created
by the OS.

Closes: #36

Author: Julian

jsonschema_specifications/_core.py

@@ -27,8 +27,12 @@ def _schemas():
     # (only 2 levels of nesting, no directories within the second level).
 
     for version in files(__package__).joinpath("schemas").iterdir():
+        if version.name.startswith("."):
+            continue
         for child in version.iterdir():
             children = [child] if child.is_file() else child.iterdir()
             for path in children:
+                if path.name.startswith("."):
+                    continue
                 contents = json.loads(path.read_text(encoding="utf-8"))
                 yield Resource.from_contents(contents)

jsonschema_specifications/tests/test_jsonschema_specifications.py

@@ -1,4 +1,7 @@
 from collections.abc import Mapping
+from pathlib import Path
+
+import pytest
 
 from jsonschema_specifications import REGISTRY
 
@@ -12,3 +15,27 @@ def test_it_contains_metaschemas():
 
 def test_it_is_crawled():
     assert REGISTRY.crawl() == REGISTRY
+
+
+@pytest.mark.parametrize(
+    "ignored_relative_path",
+    ["schemas/.DS_Store", "schemas/draft7/.DS_Store"],
+)
+def test_it_copes_with_dotfiles(ignored_relative_path):
+    """
+    Ignore files like .DS_Store if someone has actually caused one to exist.
+
+    We test here through the private interface as of course the global has
+    already loaded our schemas.
+    """
+
+    import jsonschema_specifications
+
+    package = Path(jsonschema_specifications.__file__).parent
+
+    ignored = package / ignored_relative_path
+    ignored.touch()
+    try:
+        list(jsonschema_specifications._schemas())
+    finally:
+        ignored.unlink()

noxfile.py

@@ -66,7 +66,7 @@ def typing(session):
     """
     Check static typing.
     """
-    session.install("mypy", ROOT)
+    session.install("mypy", "pytest", ROOT)
     session.run("python", "-m", "mypy", PACKAGE)