Apply suggestions from code review

Author: asford

README.rst

@@ -38,7 +38,7 @@ Depending on your editor, the configuration (found in a file called mypy-ls.cfg
 
 ``dmypy`` (default is False) executes via `dmypy run` rather than `mypy`.
 
-This uses the `dmypy` daemon and may dramatically improve the responsiveness of the `pyls` server.
+This uses the `dmypy` daemon and may dramatically improve the responsiveness of the `pylsp` server.
 
 Depending on your editor, the configuration (found in a file called mypy-ls.cfg in your workspace or a parent directory) should be roughly like this:
 

mypy_ls/plugin.py

@@ -31,7 +31,7 @@
 # Returning an empty diagnostic clears the diagnostic result,
 # so store a cache of last diagnostics for each file a-la the pylint plugin,
 # so we can return some potentially-stale diagnostics.
-# https://github.com/palantir/python-language-server/blob/0.36.2/pyls/plugins/pylint_lint.py#L52-L59
+# https://github.com/python-lsp/python-lsp-server/blob/v1.0.1/pylsp/plugins/pylint_lint.py#L55-L62
 last_diagnostics : Dict[str, List] = collections.defaultdict(list)
 
 def parse_line(line: str, document: Optional[Document] = None) -> Optional[Dict[str, Any]]:
@@ -168,25 +168,25 @@ def pyls_lint(config: Config, workspace: Workspace, document: Document,
             "silent"
         ])
 
-        log.info(f"executing mypy args={args}")
+        log.info(f"executing mypy args = %s", args)
         report, errors, _ = mypy_api.run(args)
     else:
         args = ["run", "--"] + args
 
         log.info(f"executing dmypy args={args}")
         report, errors, _ = mypy_api.run_dmypy(args)
 
-    log.debug("report: \n" + report)
+    log.debug("report:\n%s", report)
     log.debug("errors: \n" + errors)
 
     diagnostics = []
     for line in report.splitlines():
-        log.debug(f"parsing: line={line}")
+        log.debug(f"parsing: line = %r", line)
         diag = parse_line(line, document)
         if diag:
             diagnostics.append(diag)
 
-    logging.info("mypy-ls len(diagnostics) = %s", len(diagnostics))
+    log.info("mypy-ls len(diagnostics) = %s", len(diagnostics))
 
     last_diagnostics[document.path] = diagnostics
     return diagnostics
@@ -228,7 +228,7 @@ def init(workspace: str) -> Dict[str, str]:
 
     """
     # On windows the path contains \\ on linux it contains / all the code works with /
-    log.info(f"init workspace={workspace}")
+    log.info(f"init workspace = %s", workspace)
     workspace = workspace.replace("\\", "/")
 
     configuration = {}
@@ -248,7 +248,7 @@ def init(workspace: str) -> Dict[str, str]:
         tmpFile = tempfile.NamedTemporaryFile('w', delete=False)
         tmpFile.close()
 
-    log.info(f"mypyConfigFile={mypyConfigFile} configuration={configuration}")
+    log.info(f"mypyConfigFile = %s configuration = %s", mypyConfigFile, configuration)
     return configuration