Make the match_exclude_patterns logic os independent

Just convert windows paths to unix (a ilke) paths, so d:\My Documents\my_file.py becomes d:/My Documents/my_file.py

Then you can reuse the configured exclude patterns for both windows and unix (a like) platforms.

fds

Author: maerteijn

README.rst

@@ -46,7 +46,7 @@ Configuration
     With this option, pylsp-mypy will report when mypy is running, given your editor supports LSP progress reporting. For small files this might produce annoying flashing in your editor, especially in with ``live_mode``. For large projects, enabling this can be helpful to assure yourself whether mypy is still running.
 
 ``exclude`` (default is ``[]``) A list of regular expressions which should be ignored.
-    The ``mypy`` runner wil not be invoked when a document path is matched by one of the expressions. Note that this differs from the ``exclude`` directive of a ``mypy`` config which is only used for recursively discovering files when mypy is invoked on a whole directory.
+    The ``mypy`` runner wil not be invoked when a document path is matched by one of the expressions. Note that this differs from the ``exclude`` directive of a ``mypy`` config which is only used for recursively discovering files when mypy is invoked on a whole directory. For both windows or unix platforms you should use forward slashes (``/``) to indicate paths.
 
 This project supports the use of ``pyproject.toml`` for configuration. It is in fact the preferred way. Using that your configuration could look like this:
 

pylsp_mypy/plugin.py

@@ -143,12 +143,10 @@ def didSettingsChange(workspace: str, settings: Dict[str, Any]) -> None:
 
 
 def match_exclude_patterns(document_path: str, exclude_patterns: list) -> bool:
-    for pattern in exclude_patterns:
-        # This makes sure that \\ characters (and other unicode characters) are
-        # escaped first so the regex matcher will be able to parse them correctly.
-        # Especially useful for matching windows paths without any bad escape errors
-        pattern = pattern.encode("unicode-escape").decode()
+    """Check if the current document path matches any of the configures exlude patterns."""
+    document_path = document_path.replace(os.sep, "/")
 
+    for pattern in exclude_patterns:
         try:
             if re.search(pattern, document_path):
                 log.debug(f"{document_path} matches " f"exclude pattern '{pattern}'")

test/test_plugin.py

@@ -4,7 +4,7 @@
 import sys
 from pathlib import Path
 from typing import Dict
-from unittest.mock import Mock
+from unittest.mock import Mock, patch
 
 import pytest
 from mypy import api as mypy_api
@@ -331,29 +331,31 @@ def foo():
 
 
 @pytest.mark.parametrize(
-    "document_path,pattern,pattern_matched",
+    "document_path,pattern,os_sep,pattern_matched",
     (
-        ("/workspace/my-file.py", "/someting-else", False),
-        ("/workspace/my-file.py", "^/workspace$", False),
-        ("/workspace/my-file.py", "/workspace", True),
-        ("/workspace/my-file.py", "^/workspace(.*)$", True),
+        ("/workspace/my-file.py", "/someting-else", "/", False),
+        ("/workspace/my-file.py", "^/workspace$", "/", False),
+        ("/workspace/my-file.py", "/workspace", "/", True),
+        ("/workspace/my-file.py", "^/workspace(.*)$", "/", True),
         # This is a broken regex (missing ')'), but should not choke
-        ("/workspace/my-file.py", "/((workspace)", False),
+        ("/workspace/my-file.py", "/((workspace)", "/", False),
         # Windows paths are tricky with all those \\ and unintended escape,
         # characters but they should 'just' work
-        ("d:\\a\\my-file.py", "\\a", True),
+        ("d:\\a\\my-file.py", "/a", "\\", True),
         (
             "d:\\a\\pylsp-mypy\\pylsp-mypy\\test\\test_plugin.py",
-            "d:\\a\\pylsp-mypy\\pylsp-mypy\\test\\test_plugin.py",
+            "/a/pylsp-mypy/pylsp-mypy/test/test_plugin.py",
+            "\\",
             True,
         ),
     ),
 )
-def test_match_exclude_patterns(document_path, pattern, pattern_matched):
-    assert (
-        plugin.match_exclude_patterns(document_path=document_path, exclude_patterns=[pattern])
-        is pattern_matched
-    )
+def test_match_exclude_patterns(document_path, pattern, os_sep, pattern_matched):
+    with patch("os.sep", new=os_sep):
+        assert (
+            plugin.match_exclude_patterns(document_path=document_path, exclude_patterns=[pattern])
+            is pattern_matched
+        )
 
 
 def test_config_exclude(tmpdir, workspace):
@@ -365,6 +367,8 @@ def test_config_exclude(tmpdir, workspace):
     diags = plugin.pylsp_lint(workspace._config, workspace, doc, is_saved=False)
     assert diags[0]["message"] == TYPE_ERR_MSG
 
-    workspace.update_config({"pylsp": {"plugins": {"pylsp_mypy": {"exclude": [doc.path]}}}})
+    # Add the path of our document to the exclude patterns
+    exclude_path = doc.path.replace(os.sep, "/")
+    workspace.update_config({"pylsp": {"plugins": {"pylsp_mypy": {"exclude": [exclude_path]}}}})
     diags = plugin.pylsp_lint(workspace._config, workspace, doc, is_saved=False)
     assert diags == []