Skip to content

Commit 9b79576

Browse files
authored
Add version support to workspace/publishDiagnostics (#565)
1 parent cf3cea1 commit 9b79576

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

pylsp/python_lsp.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,13 +442,13 @@ def lint(self, doc_uri, is_saved):
442442
workspace = self._match_uri_to_workspace(doc_uri)
443443
document_object = workspace.documents.get(doc_uri, None)
444444
if isinstance(document_object, Document):
445-
self._lint_text_document(doc_uri, workspace, is_saved=is_saved)
445+
self._lint_text_document(doc_uri, workspace, is_saved, document_object.version)
446446
elif isinstance(document_object, Notebook):
447447
self._lint_notebook_document(document_object, workspace)
448448

449-
def _lint_text_document(self, doc_uri, workspace, is_saved):
449+
def _lint_text_document(self, doc_uri, workspace, is_saved, doc_version=None):
450450
workspace.publish_diagnostics(
451-
doc_uri, flatten(self._hook("pylsp_lint", doc_uri, is_saved=is_saved))
451+
doc_uri, flatten(self._hook("pylsp_lint", doc_uri, is_saved=is_saved)), doc_version,
452452
)
453453

454454
def _lint_notebook_document(self, notebook_document, workspace):

pylsp/workspace.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,18 @@ def update_config(self, settings):
176176
def apply_edit(self, edit):
177177
return self._endpoint.request(self.M_APPLY_EDIT, {"edit": edit})
178178

179-
def publish_diagnostics(self, doc_uri, diagnostics):
179+
def publish_diagnostics(self, doc_uri, diagnostics, doc_version=None):
180+
params = {
181+
"uri": doc_uri,
182+
"diagnostics": diagnostics,
183+
}
184+
185+
if doc_version:
186+
params["version"] = doc_version
187+
180188
self._endpoint.notify(
181189
self.M_PUBLISH_DIAGNOSTICS,
182-
params={"uri": doc_uri, "diagnostics": diagnostics},
190+
params=params,
183191
)
184192

185193
@contextmanager

0 commit comments

Comments
 (0)