Merge pull request #527 from orishoshan/master

Propagate exceptions from the flask-restplus handler if propagate exceptions is enabled

Author: SteadBytes

flask_restplus/api.py

@@ -592,6 +592,13 @@ def handle_error(self, e):
         '''
         got_request_exception.send(current_app._get_current_object(), exception=e)
 
+        if not isinstance(e, HTTPException) and current_app.propagate_exceptions:
+            exc_type, exc_value, tb = sys.exc_info()
+            if exc_value is e:
+                raise
+            else:
+                raise e
+
         include_message_in_response = current_app.config.get("ERROR_INCLUDE_MESSAGE", True)
         default_data = {}
 

tests/test_errors.py

@@ -291,12 +291,12 @@ def get(self):
 
         app.config['PROPAGATE_EXCEPTIONS'] = True
 
-        response = client.get('/api/test/')
-        assert response.status_code == 500
-        assert response.content_type == 'application/json'
-
-        data = json.loads(response.data.decode('utf8'))
-        assert 'message' in data
+        # From the Flask docs:
+        # PROPAGATE_EXCEPTIONS
+        # Exceptions are re-raised rather than being handled by the app’s error handlers.
+        # If not set, this is implicitly true if TESTING or DEBUG is enabled.
+        with pytest.raises(Exception):
+            client.get('/api/test/')
 
     def test_custom_default_errorhandler(self, app, client):
         api = restplus.Api(app)