Skip to content

Documentation improvements #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2020
Merged

Documentation improvements #112

merged 2 commits into from
May 8, 2020

Conversation

ziirish
Copy link
Contributor

@ziirish ziirish commented Apr 12, 2020

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          19       19           
  Lines        2696     2696           
=======================================
  Hits         2613     2613           
  Misses         83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e186dc4...f4ea9b4. Read the comment docs.

Copy link
Contributor

@SteadBytes SteadBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of minor typos and then we can merge!

@ziirish
Copy link
Contributor Author

ziirish commented Apr 24, 2020

Thanks for the review!

I'll resolve the comment ASAP.

Adding documentation on how to migrate from Flask-RESTPlus to Flask-RESTX.
I also added a note about the fork.
@SteadBytes
Copy link
Contributor

@ziirish I think you've hit all my review comments, are you happy with this now? If so we can merge 😊

@ziirish
Copy link
Contributor Author

ziirish commented May 7, 2020

Yes, we're good to go ;)

@SteadBytes SteadBytes self-requested a review May 8, 2020 08:42
@SteadBytes SteadBytes merged commit 50c54f0 into master May 8, 2020
@SteadBytes SteadBytes deleted the doc-options branch May 8, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants