Skip to content

Fix Issue #164: generate choices schema without collectionFormat #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Fix Issue #164: generate choices schema without collectionFormat #165

merged 2 commits into from
Jul 15, 2020

Conversation

leopold-p
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #165 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files          19       19              
  Lines        2696     2695       -1     
==========================================
- Hits         2613     2612       -1     
  Misses         83       83              
Impacted Files Coverage Δ
flask_restx/reqparse.py 98.72% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b43ba...3c318cf. Read the comment docs.

@leopold-p
Copy link
Author

i have no idea what coverage wants from me

@peterjwest
Copy link
Contributor

By removing a line of code, you've technically reduced the coverage percentage, so annoyingly, to make this pass you'd need to add a test that adds a new line of coverage, or make some code take more lines than it used to 😅

@leopold-p
Copy link
Author

Do we have to do codecov's bidding in obvious cases like this? Adding lines of code just to please a tool is insane.

@peterjwest
Copy link
Contributor

I agree with you, but I'm not associated with this project, sorry!

@ziirish
Copy link
Contributor

ziirish commented Jul 15, 2020

Hello,

No problem for the "coverage failure".
But this PR clearly lacks some context.

What are you trying to solve?
Why?
etc.

This is explained in our CONTRIBUTING guidelines.

@peterjwest
Copy link
Contributor

@ziirish the commits reference a bug originally raised in flask restplus:
noirbizarre/flask-restplus#488

@ziirish
Copy link
Contributor

ziirish commented Jul 15, 2020

Oh yes, my bad. I overlooked the commit messages.

@j5awry j5awry self-requested a review July 15, 2020 17:09
@ziirish ziirish merged commit a28f9c1 into python-restx:master Jul 15, 2020
@leopold-p leopold-p deleted the fix_choices_schema branch July 15, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants