Skip to content

Fix Float field handling of None values #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TVLIgnacy
Copy link

Resolves issue #240 by making sure a None value is not attempted to be converted to a float

Resolves issue python-restx#240 by making sure a None value is not attempted to be converted to a float
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #277 (54d7c3a) into master (3614028) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   96.86%   96.83%   -0.04%     
==========================================
  Files          19       19              
  Lines        2712     2714       +2     
==========================================
+ Hits         2627     2628       +1     
- Misses         85       86       +1     
Impacted Files Coverage Δ
flask_restx/fields.py 96.43% <50.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3614028...9a3ffd9. Read the comment docs.

@ziirish
Copy link
Contributor

ziirish commented Feb 4, 2021

Hello,

Thanks for your contribution.
Could you just add a simple test-case about the issue you are fixing here?

Copy link
Contributor

@ziirish ziirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd prefer this change to come with a proper test-case.

Thanks

@j5awry
Copy link
Contributor

j5awry commented Jun 1, 2021

Merged in #327 which includes the code from this PR + the earlier requested test. Closing this PR.

@j5awry j5awry closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants