Icon: warn for wrong color value #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocefpaf what do you think, useful or unnecessary? |
It is something nice to have. Let's merge it! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Iconclass has two color arguments: one for the marker, one for the icon. The color for the icon can be a color name or any hex color. The color for the marker must be one of a set of values, otherwise the color will default to red.This PR adds a check on the color argument a user provides. If it is not in the set of allowed colors, a warning is raised.
I used a warning instead of an exception because even with a wrong color value the map will render normally and it will display without errors. The color will just not be as expected.