Skip to content

Fix JS error in Draw plugin export option #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 21, 2019

Conversation

fullonic
Copy link
Contributor

This PR fix #1179

@Conengmo Conengmo changed the title Fix1179 Fix JS error in Draw plugin export option Jul 21, 2019
@Conengmo Conengmo merged commit f16fe2a into python-visualization:master Jul 21, 2019
@Conengmo
Copy link
Member

Nice @fullonic! Good find and thanks for the fix.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 22, 2019

@Conengmo I'm planning on a new release with this fix. Do you have any more PRs you would like to include?

@Conengmo
Copy link
Member

Good call, let's do a release indeed. I would like to include #1169, but that test needs a change. Let's wait a day and see if we get a reply on that, otherwise I can push a change to that branch.

@Conengmo
Copy link
Member

@ocefpaf it's ready! Let's do a release. I wrote the changelog: c1d76e9

Since we include a new feature (the LocateControl) plugin and we bumped Leaflet from 1.4.0 to 1.5.1 I figured this shouldn't be a patch release, but should be 0.10.0. Would you agree? I'm also okay with doing 0.9.2, but then you'd have to change the number in the changelog first before releasing.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 24, 2019

but should be 0.10.0. Would you agree

👍

Working on it today. Thanks!

@fullonic
Copy link
Contributor Author

fullonic commented Jul 24, 2019

@Conengmo , LocateControl was released on version 0.9.0 hehe 👍

- Add Locate Control plugin (fullonic #1116)

@Conengmo
Copy link
Member

Seems you're right. Weird, because the commit showed up in the diff from 0.9.1 to 0.10.0: v0.9.1...v0.10.0 I suppose these commits got snuck in again on another PR that wasn't squashed. @ocefpaf let's squash most PR's so it's easier to make the changelog.

@fullonic fullonic deleted the fix1179 branch July 25, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Draw Plugin] TypeError: document.getElementById(...) is null
3 participants