-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix JS error in Draw plugin export option #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update my fork
Update master branch
Update master
Update branch
Update master branch
Nice @fullonic! Good find and thanks for the fix. |
@Conengmo I'm planning on a new release with this fix. Do you have any more PRs you would like to include? |
Good call, let's do a release indeed. I would like to include #1169, but that test needs a change. Let's wait a day and see if we get a reply on that, otherwise I can push a change to that branch. |
@ocefpaf it's ready! Let's do a release. I wrote the changelog: c1d76e9 Since we include a new feature (the LocateControl) plugin and we bumped Leaflet from 1.4.0 to 1.5.1 I figured this shouldn't be a patch release, but should be 0.10.0. Would you agree? I'm also okay with doing 0.9.2, but then you'd have to change the number in the changelog first before releasing. |
👍 Working on it today. Thanks! |
Seems you're right. Weird, because the commit showed up in the diff from 0.9.1 to 0.10.0: v0.9.1...v0.10.0 I suppose these commits got snuck in again on another PR that wasn't squashed. @ocefpaf let's squash most PR's so it's easier to make the changelog. |
This PR fix #1179