Remove deprecation warning for floats

Author: pablogsal

Lib/test/test_math.py

@@ -498,20 +498,18 @@ def testFabs(self):
 
     def testFactorial(self):
         self.assertEqual(math.factorial(0), 1)
-        with self.assertWarns(DeprecationWarning):
-            self.assertEqual(math.factorial(0.0), 1)
-            total = 1
-            for i in range(1, 1000):
-                total *= i
-                self.assertEqual(math.factorial(i), total)
-                self.assertEqual(math.factorial(float(i)), total)
-                self.assertEqual(math.factorial(i), py_factorial(i))
+        self.assertEqual(math.factorial(0.0), 1)
+        total = 1
+        for i in range(1, 1000):
+            total *= i
+            self.assertEqual(math.factorial(i), total)
+            self.assertEqual(math.factorial(float(i)), total)
+            self.assertEqual(math.factorial(i), py_factorial(i))
         self.assertRaises(ValueError, math.factorial, -1)
-        with self.assertWarns(DeprecationWarning):
-            self.assertRaises(ValueError, math.factorial, -1.0)
-            self.assertRaises(ValueError, math.factorial, -10**100)
-            self.assertRaises(ValueError, math.factorial, -1e100)
-            self.assertRaises(ValueError, math.factorial, math.pi)
+        self.assertRaises(ValueError, math.factorial, -1.0)
+        self.assertRaises(ValueError, math.factorial, -10**100)
+        self.assertRaises(ValueError, math.factorial, -1e100)
+        self.assertRaises(ValueError, math.factorial, math.pi)
 
     def testFactorialNonIntegers(self):
         self.assertRaises(TypeError, math.factorial, decimal.Decimal(5.2))
@@ -523,8 +521,7 @@ def testFactorialHugeInputs(self):
         # Currently raises ValueError for inputs that are too large
         # to fit into a C long.
         self.assertRaises(OverflowError, math.factorial, 10**100)
-        with self.assertWarns(DeprecationWarning):
-            self.assertRaises(OverflowError, math.factorial, 1e100)
+        self.assertRaises(OverflowError, math.factorial, 1e100)
 
     def testFloor(self):
         self.assertRaises(TypeError, math.floor)

Modules/mathmodule.c

@@ -1671,16 +1671,10 @@ math_factorial(PyObject *module, PyObject *arg)
             return NULL;
         x = PyLong_AsLongAndOverflow(lx, &overflow);
         Py_DECREF(lx);
-        if (PyErr_WarnEx(PyExc_DeprecationWarning,
-                "Passing float instances to math.factorial will be "
-                "removed in future versions.", 1) < 0) {
-            return NULL;
-        }
-
     }
     else{
         pyint_form = PyNumber_Index(arg);
-        if( pyint_form == NULL){
+        if(pyint_form == NULL){
             return NULL;
         }
         x = PyLong_AsLongAndOverflow(pyint_form, &overflow);