Skip to content

Commit 05a72f1

Browse files
bpo-21446: Update reload fixer to use importlib (GH-8391)
(cherry picked from commit 7a3056f) Co-authored-by: Berker Peksag <[email protected]>
1 parent 14f58f0 commit 05a72f1

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

Doc/library/2to3.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ and off individually. They are described here in more detail.
385385
386386
.. 2to3fixer:: reload
387387
388-
Converts :func:`reload` to :func:`imp.reload`.
388+
Converts :func:`reload` to :func:`importlib.reload`.
389389
390390
.. 2to3fixer:: renames
391391

Lib/lib2to3/fixes/fix_reload.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Fixer for reload().
22
3-
reload(s) -> imp.reload(s)"""
3+
reload(s) -> importlib.reload(s)"""
44

55
# Local imports
66
from .. import fixer_base
@@ -32,7 +32,7 @@ def transform(self, node, results):
3232
if (obj.type == self.syms.argument and
3333
obj.children[0].value == '**'):
3434
return # Make no change.
35-
names = ('imp', 'reload')
35+
names = ('importlib', 'reload')
3636
new = ImportAndCall(node, results, names)
37-
touch_import(None, 'imp', node)
37+
touch_import(None, 'importlib', node)
3838
return new

Lib/lib2to3/tests/test_fixers.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,30 +290,30 @@ class Test_reload(FixerTestCase):
290290

291291
def test(self):
292292
b = """reload(a)"""
293-
a = """import imp\nimp.reload(a)"""
293+
a = """import importlib\nimportlib.reload(a)"""
294294
self.check(b, a)
295295

296296
def test_comment(self):
297297
b = """reload( a ) # comment"""
298-
a = """import imp\nimp.reload( a ) # comment"""
298+
a = """import importlib\nimportlib.reload( a ) # comment"""
299299
self.check(b, a)
300300

301301
# PEP 8 comments
302302
b = """reload( a ) # comment"""
303-
a = """import imp\nimp.reload( a ) # comment"""
303+
a = """import importlib\nimportlib.reload( a ) # comment"""
304304
self.check(b, a)
305305

306306
def test_space(self):
307307
b = """reload( a )"""
308-
a = """import imp\nimp.reload( a )"""
308+
a = """import importlib\nimportlib.reload( a )"""
309309
self.check(b, a)
310310

311311
b = """reload( a)"""
312-
a = """import imp\nimp.reload( a)"""
312+
a = """import importlib\nimportlib.reload( a)"""
313313
self.check(b, a)
314314

315315
b = """reload(a )"""
316-
a = """import imp\nimp.reload(a )"""
316+
a = """import importlib\nimportlib.reload(a )"""
317317
self.check(b, a)
318318

319319
def test_unchanged(self):
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
The :2to3fixer:`reload` fixer now uses :func:`importlib.reload` instead of
2+
deprecated :func:`imp.reload`.

0 commit comments

Comments
 (0)